From: Vojtech Pavlik <vojtech@suse.cz>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-input@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org,
linux-joystick@atrey.karlin.mff.cuni.cz
Subject: Re: [2.6 patch] drivers/input/: possible cleanups
Date: Fri, 4 Nov 2005 13:42:07 +0100 [thread overview]
Message-ID: <20051104124207.GA4937@ucw.cz> (raw)
In-Reply-To: <20051104123541.GC5587@stusta.de>
On Fri, Nov 04, 2005 at 01:35:41PM +0100, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - make needlessly glbal code static
Agreed.
> - gameport/gameport: #if 0 the unused global function gameport_reconnect
That one should be an EXPORT_SYMBOL() API. If the export is missing,
then that's the bug that needs to be fixed.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> drivers/input/gameport/gameport.c | 2 ++
> drivers/input/joystick/twidjoy.c | 4 ++--
> drivers/input/touchscreen/mk712.c | 2 +-
> 3 files changed, 5 insertions(+), 3 deletions(-)
>
> --- linux-2.6.14-rc5-mm1-full/drivers/input/joystick/twidjoy.c.old 2005-11-04 11:37:38.000000000 +0100
> +++ linux-2.6.14-rc5-mm1-full/drivers/input/joystick/twidjoy.c 2005-11-04 11:38:01.000000000 +0100
> @@ -265,13 +265,13 @@
> * The functions for inserting/removing us as a module.
> */
>
> -int __init twidjoy_init(void)
> +static int __init twidjoy_init(void)
> {
> serio_register_driver(&twidjoy_drv);
> return 0;
> }
>
> -void __exit twidjoy_exit(void)
> +static void __exit twidjoy_exit(void)
> {
> serio_unregister_driver(&twidjoy_drv);
> }
> --- linux-2.6.14-rc5-mm1-full/drivers/input/touchscreen/mk712.c.old 2005-11-04 11:38:20.000000000 +0100
> +++ linux-2.6.14-rc5-mm1-full/drivers/input/touchscreen/mk712.c 2005-11-04 11:38:29.000000000 +0100
> @@ -154,7 +154,7 @@
> spin_unlock_irqrestore(&mk712_lock, flags);
> }
>
> -int __init mk712_init(void)
> +static int __init mk712_init(void)
> {
> int err;
>
> --- linux-2.6.14-rc5-mm1-full/drivers/input/gameport/gameport.c.old 2005-11-04 11:38:52.000000000 +0100
> +++ linux-2.6.14-rc5-mm1-full/drivers/input/gameport/gameport.c 2005-11-04 11:39:32.000000000 +0100
> @@ -637,10 +637,12 @@
> gameport_queue_event(gameport, NULL, GAMEPORT_RESCAN);
> }
>
> +#if 0
> void gameport_reconnect(struct gameport *gameport)
> {
> gameport_queue_event(gameport, NULL, GAMEPORT_RECONNECT);
> }
> +#endif /* 0 */
>
> /*
> * Submits register request to kgameportd for subsequent execution.
>
>
--
Vojtech Pavlik
SuSE Labs, SuSE CR
next prev parent reply other threads:[~2005-11-04 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-04 12:35 [2.6 patch] drivers/input/: possible cleanups Adrian Bunk
2005-11-04 12:42 ` Vojtech Pavlik [this message]
2005-11-04 12:57 ` Adrian Bunk
2005-11-04 13:12 ` Vojtech Pavlik
2005-11-05 15:09 ` Adrian Bunk
2005-11-05 20:20 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051104124207.GA4937@ucw.cz \
--to=vojtech@suse.cz \
--cc=bunk@stusta.de \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-joystick@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox