From: Adrian Bunk <bunk@stusta.de>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: linux-input@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org,
linux-joystick@atrey.karlin.mff.cuni.cz
Subject: Re: [2.6 patch] drivers/input/: possible cleanups
Date: Fri, 4 Nov 2005 13:57:42 +0100 [thread overview]
Message-ID: <20051104125742.GE5587@stusta.de> (raw)
In-Reply-To: <20051104124207.GA4937@ucw.cz>
On Fri, Nov 04, 2005 at 01:42:07PM +0100, Vojtech Pavlik wrote:
> On Fri, Nov 04, 2005 at 01:35:41PM +0100, Adrian Bunk wrote:
> > This patch contains the following possible cleanups:
> > - make needlessly glbal code static
>
> Agreed.
>
> > - gameport/gameport: #if 0 the unused global function gameport_reconnect
>
> That one should be an EXPORT_SYMBOL() API. If the export is missing,
> then that's the bug that needs to be fixed.
>...
There isn't even a header providing a function prototype which is quite
strange for a part of an API.
> Vojtech Pavlik
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2005-11-04 12:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-04 12:35 [2.6 patch] drivers/input/: possible cleanups Adrian Bunk
2005-11-04 12:42 ` Vojtech Pavlik
2005-11-04 12:57 ` Adrian Bunk [this message]
2005-11-04 13:12 ` Vojtech Pavlik
2005-11-05 15:09 ` Adrian Bunk
2005-11-05 20:20 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051104125742.GE5587@stusta.de \
--to=bunk@stusta.de \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-joystick@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox