From: Arjan van de Ven <arjanv@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Andreas Herrmann <AHERRMAN@de.ibm.com>,
viro@ftp.linux.org.uk, heicars2@de.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH resubmit] do_mount: reduce stack consumption
Date: Fri, 4 Nov 2005 18:45:06 +0100 [thread overview]
Message-ID: <20051104174506.GA4720@devserv.devel.redhat.com> (raw)
In-Reply-To: <20051104094212.23f07ce7.akpm@osdl.org>
On Fri, Nov 04, 2005 at 09:42:12AM -0800, Andrew Morton wrote:
> Andreas Herrmann <AHERRMAN@de.ibm.com> wrote:
> >
> > Obviously you missed the point that (depending on the compiler version,
> > options etc.) do_move_mount() and do_add_mount() can be inlined.
>
> I think we found a way of preventing the 3.x compiler from doing that. Arjan,
> do you recall where we ended up with that problem?
it was mostly caused by -funit-at-a-time that caused 3.x to go haywire. You
need to turn that off in general.
the real fix is in gcc 4.x (4.1 at least) where gcc got a lot smarter about
stack slot lifetimes
next prev parent reply other threads:[~2005-11-04 17:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-04 15:53 [PATCH resubmit] do_mount: reduce stack consumption Andreas Herrmann
2005-11-04 17:42 ` Andrew Morton
2005-11-04 17:45 ` Arjan van de Ven [this message]
2005-11-04 18:37 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2005-11-04 10:50 Heiko Carstens
2005-11-04 11:48 ` Al Viro
2005-11-04 12:57 ` Heiko Carstens
2005-11-04 14:06 ` Al Viro
2005-11-04 22:03 ` Heiko Carstens
2005-11-04 16:48 ` Andrew Morton
2005-11-04 21:27 ` Heiko Carstens
2005-11-04 23:55 ` Adrian Bunk
2005-11-05 0:08 ` Andrew Morton
2005-11-05 1:15 ` cplk
2005-11-05 1:37 ` Andrew Morton
2005-11-05 5:37 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051104174506.GA4720@devserv.devel.redhat.com \
--to=arjanv@redhat.com \
--cc=AHERRMAN@de.ibm.com \
--cc=akpm@osdl.org \
--cc=heicars2@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox