public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: James Chapman <jchapman@katalix.com>,
	Michael Burian <dynmail1@gassner-waagen.at>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH: 2.6.14] i2c chips: ds1337 1/2
Date: Sat, 5 Nov 2005 08:54:40 +0100	[thread overview]
Message-ID: <20051105085440.07ddb2ce.khali@linux-fr.org> (raw)
In-Reply-To: <436A71B9.6060205@katalix.com>

Hi James, Michael, all,

> Patch for ds1337 i2c driver:
> 
> Add code to handle case where board firmware does not start the
> RTC.

I understand the idea, but I don't like the implementation. Why did you
add the initialization code to ds1337_set_datetime, rather than to
ds1337_init_client where is seems to belong?

Also, the initialization loop is way less efficient than it could be,
given the fact that the DS1337 autoincrements its address register on
write. You could at least use i2c_smbus_write_byte (instead of
i2c_smbus_write_byte_data), but even more efficient would be a block
transfer, like the ds1337_set_datetime function use.

Care to respin a patch?

Thanks,
-- 
Jean Delvare

  reply	other threads:[~2005-11-05  7:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-03 20:23 [PATCH: 2.6.14] i2c chips: ds1337 1/2 James Chapman
2005-11-05  7:54 ` Jean Delvare [this message]
2005-11-05 10:55   ` James Chapman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051105085440.07ddb2ce.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=dynmail1@gassner-waagen.at \
    --cc=jchapman@katalix.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox