From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [patch 2/5] atomic: cmpxchg
Date: Sat, 5 Nov 2005 09:13:11 +0000 [thread overview]
Message-ID: <20051105091311.GA19516@flint.arm.linux.org.uk> (raw)
In-Reply-To: <436C771D.8040703@yahoo.com.au>
On Sat, Nov 05, 2005 at 08:10:53PM +1100, Nick Piggin wrote:
> While you're here, does the assembly code for the SMP version look
> OK? You basically provided me with it but I don't think you saw its
> final form.
Looks fine. The only comment is changing the "r" (old) to be
"Ir" (old). The "I" tells the compiler that it may also use a
constant for that argument, which may allow it to optimise the
code a bit better.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-11-05 9:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-05 7:55 [patch 0/4] atomic primitives again Nick Piggin
2005-11-05 7:56 ` [patch 1/5] i386: generic cmpxchg Nick Piggin
2005-11-05 7:57 ` [patch 2/5] atomic: cmpxchg Nick Piggin
2005-11-05 7:58 ` [patch 3/5] atomic: inc_not_zero Nick Piggin
2005-11-05 7:58 ` [patch 4/5] rcu file: use atomic Nick Piggin
2005-11-05 7:59 ` [patch 5/5] atomic: dec_and_lock " Nick Piggin
2005-11-05 9:00 ` [patch 2/5] atomic: cmpxchg Russell King
2005-11-05 9:10 ` Nick Piggin
2005-11-05 9:13 ` Russell King [this message]
2005-11-05 9:21 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051105091311.GA19516@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox