From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] [DRIVER MODEL] Make other buggy drivers warn
Date: Sat, 5 Nov 2005 11:02:27 +0000 [thread overview]
Message-ID: <20051105110226.GG30315@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20051105105628.GE28438@flint.arm.linux.org.uk>
Obviously just to provoke comment from these driver authors to point
out the error of their ways, and _not_ for merging.
diff -u b/drivers/net/depca.c b/drivers/net/depca.c
--- b/drivers/net/depca.c
+++ b/drivers/net/depca.c
@@ -2083,6 +2083,7 @@ static int __init depca_module_init (voi
err |= eisa_driver_register (&depca_eisa_driver);
#endif
err |= driver_register (&depca_isa_driver);
+#warning FIXME: what if one of the above registeration functions fails
depca_platform_probe ();
return err;
diff -u b/drivers/net/tokenring/proteon.c b/drivers/net/tokenring/proteon.c
--- b/drivers/net/tokenring/proteon.c
+++ b/drivers/net/tokenring/proteon.c
@@ -384,6 +384,7 @@ static int __init proteon_init(void)
/* Probe for cards. */
if (num == 0) {
printk(KERN_NOTICE "proteon.c: No cards found.\n");
+#warning FIXME: what about unregistering the platform driver?
return (-ENODEV);
}
return (0);
diff -u b/drivers/net/tokenring/skisa.c b/drivers/net/tokenring/skisa.c
--- b/drivers/net/tokenring/skisa.c
+++ b/drivers/net/tokenring/skisa.c
@@ -394,6 +394,7 @@ static int __init sk_isa_init(void)
/* Probe for cards. */
if (num == 0) {
printk(KERN_NOTICE "skisa.c: No cards found.\n");
+#warning FIXME: what about unregistering the platform driver?
return (-ENODEV);
}
return (0);
diff -u b/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
--- b/drivers/usb/gadget/dummy_hcd.c
+++ b/drivers/usb/gadget/dummy_hcd.c
@@ -1981,9 +1981,11 @@
* statically allocated. */
static void
dummy_udc_release (struct device *dev) {}
+#warning FIXME: device release code in the module which unregisters the device is buggy
static void
dummy_hcd_release (struct device *dev) {}
+#warning FIXME: device release code in the module which unregisters the device is buggy
static struct platform_device the_udc_pdev = {
.name = (char *) gadget_name,
diff -u b/sound/core/init.c b/sound/core/init.c
--- b/sound/core/init.c
+++ b/sound/core/init.c
@@ -694,6 +694,7 @@
void snd_generic_device_release(struct device *dev)
{
+#warning FIXME: release functions must not be empty
}
static int snd_generic_device_register(snd_card_t *card)
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-11-05 11:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-05 10:56 [PATCH] [DRIVER MODEL] Improved dynamically allocated platform_device interface Russell King
2005-11-05 10:57 ` [PATCH] [DRIVER MODEL] Fix depca Russell King
2005-11-05 10:58 ` [PATCH] [DRIVER MODEL] Fix jazzsonic Russell King
2005-11-05 10:58 ` [PATCH] [DRIVER MODEL] Fix macsonic Russell King
2005-11-05 10:59 ` [PATCH] [DRIVER MODEL] Fix arcfb Russell King
2005-11-05 10:59 ` [PATCH] [DRIVER MODEL] Fix gbefb Russell King
2005-11-05 11:00 ` [PATCH] [DRIVER MODEL] Fix sgivwfb Russell King
2005-11-05 11:02 ` Russell King [this message]
2005-11-05 15:42 ` [PATCH] [DRIVER MODEL] Improved dynamically allocated platform_device interface Greg KH
2005-11-05 17:19 ` Russell King
2005-11-05 19:40 ` Greg KH
2005-11-05 17:23 ` Russell King
2005-11-05 21:38 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051105110226.GG30315@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox