Re: [2.6 patch] drivers/input/: possible cleanups

Vojtech Pavlik
2005-11-04T13:12:30Z

On Fri, Nov 04, 2005 at 01:57:42PM +0100, Adrian Bunk wrote:

> On Fri, Nov 04, 2005 at 01:42:07PM +0100, Vojtech Pavlik wrote:
> > On Fri, Nov 04, 2005 at 01:35:41PM +0100, Adrian Bunk wrote:
> > > This patch contains the following possible cleanups:
> > > - make needlessly glbal code static
> >
> > Agreed.
> >
> > > - gameport/gameport: #if 0 the unused global function gameport_reconnect
> >
> > That one should be an EXPORT_SYMBOL() API. If the export is missing,
> > then that's the bug that needs to be fixed.
> >...
>
> There isn't even a header providing a function prototype which is quite
> strange for a part of an API.

It's a planned API (a mirror of what the serio abstraction does), the
drivers don't use it yet.