Re: [2.6 patch] drivers/input/: possible cleanups

Adrian Bunk
2005-11-05T15:10:04Z

On Fri, Nov 04, 2005 at 02:12:28PM +0100, Vojtech Pavlik wrote:
> On Fri, Nov 04, 2005 at 01:57:42PM +0100, Adrian Bunk wrote:
>
> > On Fri, Nov 04, 2005 at 01:42:07PM +0100, Vojtech Pavlik wrote:
> > > On Fri, Nov 04, 2005 at 01:35:41PM +0100, Adrian Bunk wrote:
> > > > This patch contains the following possible cleanups:
> > > > - make needlessly glbal code static
> > >
> > > Agreed.
> > >
> > > > - gameport/gameport: #if 0 the unused global function gameport_reconnect
> > >
> > > That one should be an EXPORT_SYMBOL() API. If the export is missing,
> > > then that's the bug that needs to be fixed.
> > >...
> >
> > There isn't even a header providing a function prototype which is quite
> > strange for a part of an API.
>
> It's a planned API (a mirror of what the serio abstraction does), the
> drivers don't use it yet.

Can you either apply my patch to #if 0 it, or (if usage is planned very
soon) add a function prototype to a header file?

In both cases, we get rid of a warning both by sparse and with the gcc
-Wmissing-prototypes flag.

> Vojtech Pavlik

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed