From: Adrian Bunk <bunk@stusta.de>
To: gregkh@suse.de
Cc: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: [2.6 patch] drivers/pci/: small cleanups
Date: Sun, 6 Nov 2005 01:45:08 +0100 [thread overview]
Message-ID: <20051106004508.GC3668@stusta.de> (raw)
This patch contains the following cleanups:
- access.c should #include "pci.h" for getting the prototypes of it's
global functions
- hotplug/shpchp_pci.c: make the needlessly global function
program_fw_provided_values() static
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/pci/access.c | 2 ++
drivers/pci/hotplug/shpchp_pci.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
--- linux-2.6.14-rc5-mm1-full/drivers/pci/access.c.old 2005-11-06 00:26:26.000000000 +0100
+++ linux-2.6.14-rc5-mm1-full/drivers/pci/access.c 2005-11-06 00:26:54.000000000 +0100
@@ -2,6 +2,8 @@
#include <linux/module.h>
#include <linux/ioport.h>
+#include "pci.h"
+
/*
* This interrupt-safe spinlock protects all accesses to PCI
* configuration space.
--- linux-2.6.14-rc5-mm1-full/drivers/pci/hotplug/shpchp_pci.c.old 2005-11-06 00:28:10.000000000 +0100
+++ linux-2.6.14-rc5-mm1-full/drivers/pci/hotplug/shpchp_pci.c 2005-11-06 00:28:17.000000000 +0100
@@ -34,7 +34,7 @@
#include "../pci.h"
#include "shpchp.h"
-void program_fw_provided_values(struct pci_dev *dev)
+static void program_fw_provided_values(struct pci_dev *dev)
{
u16 pci_cmd, pci_bctl;
struct pci_dev *cdev;
reply other threads:[~2005-11-06 0:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051106004508.GC3668@stusta.de \
--to=bunk@stusta.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox