From: "Paul E. McKenney" <paulmck@us.ibm.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, dipankar@in.ibm.com,
mingo@elte.hu, suzannew@cs.pdx.edu
Subject: Re: [PATCH] Additional/catchup RCU signal fixes for -mm
Date: Sun, 6 Nov 2005 15:02:02 -0800 [thread overview]
Message-ID: <20051106230202.GD22876@us.ibm.com> (raw)
In-Reply-To: <436E1731.16CFAE41@tv-sign.ru>
On Sun, Nov 06, 2005 at 05:46:09PM +0300, Oleg Nesterov wrote:
> Oleg Nesterov wrote:
> >
> > "Paul E. McKenney" wrote:
> > >
> > > + if (p->sighand == NULL) {
> > > + ret = 1;
> >
> > Oh, I think there is another problem here. I'll post a separate
> > message.
>
> Sorry, I was not clear. This problem is unrelated. Yes, I think we
> should drop the signal. But please note that ret = 1 (sig_ignored)
> means (surprise!) "reschedule and re-arm this timer right now" in
> cpu-timer case. It is not critical, but may be ret = 0 is better.
OK. Seems like the next firing of the timer would then see the
changed situation, so the current code should at least be safe.
Thoughts?
Thanx, Paul
next prev parent reply other threads:[~2005-11-06 23:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-05 1:36 [PATCH] Additional/catchup RCU signal fixes for -mm Paul E. McKenney
2005-11-05 16:32 ` Oleg Nesterov
2005-11-06 1:00 ` Paul E. McKenney
2005-11-06 14:17 ` Oleg Nesterov
2005-11-06 14:46 ` Oleg Nesterov
2005-11-06 23:02 ` Paul E. McKenney [this message]
2005-11-06 14:32 ` Posix timers vs exec problems Oleg Nesterov
2005-11-07 18:12 ` [PATCH] fix de_thread() vs send_group_sigqueue() race Oleg Nesterov
2005-11-08 20:36 ` Chris Wright
2005-11-08 20:55 ` Linus Torvalds
2005-11-16 23:26 ` [PATCH] sigaction should clear all signals on SIG_IGN, not just < 32 George Anzinger
2005-11-22 1:09 ` Thread group exec race -> null pointer... HELP George Anzinger
2005-11-22 14:45 ` Oleg Nesterov
2005-11-23 20:30 ` George Anzinger
2005-11-25 15:03 ` Ingo Molnar
2005-11-22 19:20 ` [PATCH] fix do_wait() vs exec() race Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051106230202.GD22876@us.ibm.com \
--to=paulmck@us.ibm.com \
--cc=akpm@osdl.org \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
--cc=suzannew@cs.pdx.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox