Re: [PATCH]: Cleanup of __alloc_pages

Andrew Morton
2005-11-08T02:44:20Z

Rohit Seth <rohit.seth@intel.com> wrote:
>
> On Mon, 2005-11-07 at 17:53 -0800, Andrew Morton wrote:
> > "Rohit, Seth" <rohit.seth@intel.com> wrote:
> > >
> > > [PATCH]: Clean up of __alloc_pages. Couple of difference from original behavior:
> > > 1- remove the initial reclaim logic
> > > 2- GFP_HIGH pages are allowed to go little below watermark sooner.
> > > 3- Search for free pages unconditionally after direct reclaim.
> >
> > Would it be possible to break these into three separate patches? The
> > cleanup part should be #1.
> >
>
> Doing the above three things as part of this clean up patch makes the
> code look extra clean...

With separate patches the changes can be better understood, and they can be
selectively dropped, and people looking for regressions with `git bisect'
will be able to pinpoint the source more accurately.

> Is there any specific issue coming out of 2 & 3
> above.

I haven't looked yet - all the changes are mixed together ;)