From: David Teigland <teigland@redhat.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-cluster@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [-mm patch] drivers/dlm/: possible cleanups
Date: Mon, 7 Nov 2005 14:04:31 -0600 [thread overview]
Message-ID: <20051107200431.GC20531@redhat.com> (raw)
In-Reply-To: <20051104120640.GB5587@stusta.de>
On Fri, Nov 04, 2005 at 01:06:40PM +0100, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - every file should #include the headers containing the prototypes for
> it's global functions
Including unnecessary headers doesn't sound right.
> - make needlessly global functions static
> - #if 0 the following unused global functions:
> - device.c: dlm_device_free_devices
> - lock.c: dlm_remove_from_waiters
> - lockspace.c: dlm_find_lockspace_name
I've removed the unused functions and added the statics.
Thanks,
Dave
next prev parent reply other threads:[~2005-11-07 20:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-04 12:06 [-mm patch] drivers/dlm/: possible cleanups Adrian Bunk
2005-11-07 20:04 ` David Teigland [this message]
2005-11-07 20:20 ` Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2005-11-07 20:04 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051107200431.GC20531@redhat.com \
--to=teigland@redhat.com \
--cc=bunk@stusta.de \
--cc=linux-cluster@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox