* [2.6 patch] drivers/isdn/: "extern inline" -> "static inline"
@ 2005-10-30 0:43 Adrian Bunk
2005-10-30 14:44 ` Simon Richter
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2005-10-30 0:43 UTC (permalink / raw)
To: kkeil, kai.germaschewski; +Cc: isdn4linux, linux-kernel
"extern inline" doesn't make much sense.
Since there's no pullphone() function this patch removes the dead
prototype.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/isdn/act2000/act2000.h | 6 +++---
drivers/isdn/act2000/capi.h | 2 +-
drivers/isdn/sc/command.c | 1 -
3 files changed, 4 insertions(+), 5 deletions(-)
--- linux-2.6.14-rc5-mm1-full/drivers/isdn/act2000/act2000.h.old 2005-10-30 02:06:09.000000000 +0200
+++ linux-2.6.14-rc5-mm1-full/drivers/isdn/act2000/act2000.h 2005-10-30 02:06:19.000000000 +0200
@@ -181,17 +181,17 @@
char regname[35]; /* Name used for request_region */
} act2000_card;
-extern __inline__ void act2000_schedule_tx(act2000_card *card)
+static inline void act2000_schedule_tx(act2000_card *card)
{
schedule_work(&card->snd_tq);
}
-extern __inline__ void act2000_schedule_rx(act2000_card *card)
+static inline void act2000_schedule_rx(act2000_card *card)
{
schedule_work(&card->rcv_tq);
}
-extern __inline__ void act2000_schedule_poll(act2000_card *card)
+static inline void act2000_schedule_poll(act2000_card *card)
{
schedule_work(&card->poll_tq);
}
--- linux-2.6.14-rc5-mm1-full/drivers/isdn/act2000/capi.h.old 2005-10-30 02:06:26.000000000 +0200
+++ linux-2.6.14-rc5-mm1-full/drivers/isdn/act2000/capi.h 2005-10-30 02:06:31.000000000 +0200
@@ -330,7 +330,7 @@
} msg;
} actcapi_msg;
-extern __inline__ unsigned short
+static inline unsigned short
actcapi_nextsmsg(act2000_card *card)
{
unsigned long flags;
--- linux-2.6.14-rc5-mm1-full/drivers/isdn/sc/command.c.old 2005-10-30 02:06:39.000000000 +0200
+++ linux-2.6.14-rc5-mm1-full/drivers/isdn/sc/command.c 2005-10-30 02:07:01.000000000 +0200
@@ -43,7 +43,6 @@
RspMessage *, int);
extern int sendmessage(int, unsigned int, unsigned int, unsigned int,
unsigned int, unsigned int, unsigned int, unsigned int *);
-extern inline void pullphone(char *, char *);
#ifdef DEBUG
/*
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] drivers/isdn/: "extern inline" -> "static inline"
2005-10-30 0:43 Adrian Bunk
@ 2005-10-30 14:44 ` Simon Richter
0 siblings, 0 replies; 3+ messages in thread
From: Simon Richter @ 2005-10-30 14:44 UTC (permalink / raw)
To: Adrian Bunk; +Cc: kkeil, kai.germaschewski, isdn4linux, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 233 bytes --]
Hi,
Adrian Bunk schrieb:
> "extern inline" doesn't make much sense.
In fact, it does[1], but not in this particular case.
Simon
[1] "if this function is not inlined, treat it as extern instead of
creating a copy in this TU".
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 374 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [2.6 patch] drivers/isdn/: "extern inline" -> "static inline"
@ 2005-11-07 21:18 Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2005-11-07 21:18 UTC (permalink / raw)
To: Andrew Morton; +Cc: kkeil, kai.germaschewski, isdn4linux, linux-kernel
"extern inline" -> "static inline"
Since there's no pullphone() function this patch removes the dead
prototype.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 30 Oct 2005
drivers/isdn/act2000/act2000.h | 6 +++---
drivers/isdn/act2000/capi.h | 2 +-
drivers/isdn/sc/command.c | 1 -
3 files changed, 4 insertions(+), 5 deletions(-)
--- linux-2.6.14-rc5-mm1-full/drivers/isdn/act2000/act2000.h.old 2005-10-30 02:06:09.000000000 +0200
+++ linux-2.6.14-rc5-mm1-full/drivers/isdn/act2000/act2000.h 2005-10-30 02:06:19.000000000 +0200
@@ -181,17 +181,17 @@
char regname[35]; /* Name used for request_region */
} act2000_card;
-extern __inline__ void act2000_schedule_tx(act2000_card *card)
+static inline void act2000_schedule_tx(act2000_card *card)
{
schedule_work(&card->snd_tq);
}
-extern __inline__ void act2000_schedule_rx(act2000_card *card)
+static inline void act2000_schedule_rx(act2000_card *card)
{
schedule_work(&card->rcv_tq);
}
-extern __inline__ void act2000_schedule_poll(act2000_card *card)
+static inline void act2000_schedule_poll(act2000_card *card)
{
schedule_work(&card->poll_tq);
}
--- linux-2.6.14-rc5-mm1-full/drivers/isdn/act2000/capi.h.old 2005-10-30 02:06:26.000000000 +0200
+++ linux-2.6.14-rc5-mm1-full/drivers/isdn/act2000/capi.h 2005-10-30 02:06:31.000000000 +0200
@@ -330,7 +330,7 @@
} msg;
} actcapi_msg;
-extern __inline__ unsigned short
+static inline unsigned short
actcapi_nextsmsg(act2000_card *card)
{
unsigned long flags;
--- linux-2.6.14-rc5-mm1-full/drivers/isdn/sc/command.c.old 2005-10-30 02:06:39.000000000 +0200
+++ linux-2.6.14-rc5-mm1-full/drivers/isdn/sc/command.c 2005-10-30 02:07:01.000000000 +0200
@@ -43,7 +43,6 @@
RspMessage *, int);
extern int sendmessage(int, unsigned int, unsigned int, unsigned int,
unsigned int, unsigned int, unsigned int, unsigned int *);
-extern inline void pullphone(char *, char *);
#ifdef DEBUG
/*
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-11-07 21:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-07 21:18 [2.6 patch] drivers/isdn/: "extern inline" -> "static inline" Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2005-10-30 0:43 Adrian Bunk
2005-10-30 14:44 ` Simon Richter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox