* [2.6 patch] drivers/md/kcopyd.c: remove kcopyd_cancel()
@ 2005-11-08 13:44 Adrian Bunk
2005-11-08 15:48 ` [dm-devel] " Alasdair G Kergon
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2005-11-08 13:44 UTC (permalink / raw)
To: Andrew Morton; +Cc: dm-devel, linux-kernel
A function that is
- not used
- empty
- without a prototype in any header file
should be removed.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 5 Nov 2005
drivers/md/kcopyd.c | 11 -----------
1 file changed, 11 deletions(-)
--- linux-2.6.14-rc5-mm1-full/drivers/md/kcopyd.c.old 2005-11-05 16:36:11.000000000 +0100
+++ linux-2.6.14-rc5-mm1-full/drivers/md/kcopyd.c 2005-11-05 17:04:45.000000000 +0100
@@ -558,16 +558,6 @@
return 0;
}
-/*
- * Cancels a kcopyd job, eg. someone might be deactivating a
- * mirror.
- */
-int kcopyd_cancel(struct kcopyd_job *job, int block)
-{
- /* FIXME: finish */
- return -1;
-}
-
/*-----------------------------------------------------------------
* Unit setup
*---------------------------------------------------------------*/
@@ -685,4 +675,3 @@
EXPORT_SYMBOL(kcopyd_client_create);
EXPORT_SYMBOL(kcopyd_client_destroy);
EXPORT_SYMBOL(kcopyd_copy);
-EXPORT_SYMBOL(kcopyd_cancel);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dm-devel] [2.6 patch] drivers/md/kcopyd.c: remove kcopyd_cancel()
2005-11-08 13:44 [2.6 patch] drivers/md/kcopyd.c: remove kcopyd_cancel() Adrian Bunk
@ 2005-11-08 15:48 ` Alasdair G Kergon
2005-11-08 16:53 ` [2.6 patch] drivers/md/kcopyd.c: #if 0 kcopyd_cancel() Adrian Bunk
0 siblings, 1 reply; 4+ messages in thread
From: Alasdair G Kergon @ 2005-11-08 15:48 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, dm-devel, linux-kernel
On Tue, Nov 08, 2005 at 02:44:19PM +0100, Adrian Bunk wrote:
> A function that is
> - not used
> - empty
> - without a prototype in any header file
> should be removed.
I'd rather you submitted a patch to complete the function and invoke it
in the appropriate place:-) But please don't remove comments indicating
missing functionality: commenting it out till it's written would be better.
Alasdair
--
agk@redhat.com
> -/*
> - * Cancels a kcopyd job, eg. someone might be deactivating a
> - * mirror.
> - */
> -int kcopyd_cancel(struct kcopyd_job *job, int block)
> -{
> - /* FIXME: finish */
> - return -1;
> -}
^ permalink raw reply [flat|nested] 4+ messages in thread* [2.6 patch] drivers/md/kcopyd.c: #if 0 kcopyd_cancel()
2005-11-08 15:48 ` [dm-devel] " Alasdair G Kergon
@ 2005-11-08 16:53 ` Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2005-11-08 16:53 UTC (permalink / raw)
To: Andrew Morton, dm-devel, linux-kernel
On Tue, Nov 08, 2005 at 03:48:28PM +0000, Alasdair G Kergon wrote:
> On Tue, Nov 08, 2005 at 02:44:19PM +0100, Adrian Bunk wrote:
> > A function that is
> > - not used
> > - empty
> > - without a prototype in any header file
> > should be removed.
>
> I'd rather you submitted a patch to complete the function and invoke it
> in the appropriate place:-) But please don't remove comments indicating
> missing functionality: commenting it out till it's written would be better.
Updated patch below.
> Alasdair
cu
Adrian
<-- snip -->
This patch #if 0's the not yet implemented global function
kcopyd_cancel().
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/md/kcopyd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-2.6.14-mm1-full/drivers/md/kcopyd.c.old 2005-11-08 17:41:31.000000000 +0100
+++ linux-2.6.14-mm1-full/drivers/md/kcopyd.c 2005-11-08 17:41:59.000000000 +0100
@@ -562,11 +562,13 @@
* Cancels a kcopyd job, eg. someone might be deactivating a
* mirror.
*/
+#if 0
int kcopyd_cancel(struct kcopyd_job *job, int block)
{
/* FIXME: finish */
return -1;
}
+#endif /* 0 */
/*-----------------------------------------------------------------
* Unit setup
@@ -685,4 +687,3 @@
EXPORT_SYMBOL(kcopyd_client_create);
EXPORT_SYMBOL(kcopyd_client_destroy);
EXPORT_SYMBOL(kcopyd_copy);
-EXPORT_SYMBOL(kcopyd_cancel);
^ permalink raw reply [flat|nested] 4+ messages in thread
* [2.6 patch] drivers/md/kcopyd.c: remove kcopyd_cancel()
@ 2005-11-05 16:31 Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2005-11-05 16:31 UTC (permalink / raw)
To: dm-devel; +Cc: linux-kernel
A function that is
- not used
- empty
- without a prototype in any header file
should be removed.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/md/kcopyd.c | 11 -----------
1 file changed, 11 deletions(-)
--- linux-2.6.14-rc5-mm1-full/drivers/md/kcopyd.c.old 2005-11-05 16:36:11.000000000 +0100
+++ linux-2.6.14-rc5-mm1-full/drivers/md/kcopyd.c 2005-11-05 17:04:45.000000000 +0100
@@ -558,16 +558,6 @@
return 0;
}
-/*
- * Cancels a kcopyd job, eg. someone might be deactivating a
- * mirror.
- */
-int kcopyd_cancel(struct kcopyd_job *job, int block)
-{
- /* FIXME: finish */
- return -1;
-}
-
/*-----------------------------------------------------------------
* Unit setup
*---------------------------------------------------------------*/
@@ -685,4 +675,3 @@
EXPORT_SYMBOL(kcopyd_client_create);
EXPORT_SYMBOL(kcopyd_client_destroy);
EXPORT_SYMBOL(kcopyd_copy);
-EXPORT_SYMBOL(kcopyd_cancel);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-11-08 16:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-08 13:44 [2.6 patch] drivers/md/kcopyd.c: remove kcopyd_cancel() Adrian Bunk
2005-11-08 15:48 ` [dm-devel] " Alasdair G Kergon
2005-11-08 16:53 ` [2.6 patch] drivers/md/kcopyd.c: #if 0 kcopyd_cancel() Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2005-11-05 16:31 [2.6 patch] drivers/md/kcopyd.c: remove kcopyd_cancel() Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox