From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>,
dm-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/md/kcopyd.c: #if 0 kcopyd_cancel()
Date: Tue, 8 Nov 2005 17:53:24 +0100 [thread overview]
Message-ID: <20051108165324.GY3847@stusta.de> (raw)
In-Reply-To: <20051108154828.GX26394@agk.surrey.redhat.com>
On Tue, Nov 08, 2005 at 03:48:28PM +0000, Alasdair G Kergon wrote:
> On Tue, Nov 08, 2005 at 02:44:19PM +0100, Adrian Bunk wrote:
> > A function that is
> > - not used
> > - empty
> > - without a prototype in any header file
> > should be removed.
>
> I'd rather you submitted a patch to complete the function and invoke it
> in the appropriate place:-) But please don't remove comments indicating
> missing functionality: commenting it out till it's written would be better.
Updated patch below.
> Alasdair
cu
Adrian
<-- snip -->
This patch #if 0's the not yet implemented global function
kcopyd_cancel().
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/md/kcopyd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-2.6.14-mm1-full/drivers/md/kcopyd.c.old 2005-11-08 17:41:31.000000000 +0100
+++ linux-2.6.14-mm1-full/drivers/md/kcopyd.c 2005-11-08 17:41:59.000000000 +0100
@@ -562,11 +562,13 @@
* Cancels a kcopyd job, eg. someone might be deactivating a
* mirror.
*/
+#if 0
int kcopyd_cancel(struct kcopyd_job *job, int block)
{
/* FIXME: finish */
return -1;
}
+#endif /* 0 */
/*-----------------------------------------------------------------
* Unit setup
@@ -685,4 +687,3 @@
EXPORT_SYMBOL(kcopyd_client_create);
EXPORT_SYMBOL(kcopyd_client_destroy);
EXPORT_SYMBOL(kcopyd_copy);
-EXPORT_SYMBOL(kcopyd_cancel);
next prev parent reply other threads:[~2005-11-08 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-08 13:44 [2.6 patch] drivers/md/kcopyd.c: remove kcopyd_cancel() Adrian Bunk
2005-11-08 15:48 ` [dm-devel] " Alasdair G Kergon
2005-11-08 16:53 ` Adrian Bunk [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-12-11 21:54 [2.6 patch] drivers/md/kcopyd.c: #if 0 kcopyd_cancel() Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051108165324.GY3847@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox