Re: Linux 2.4.32-rc3

[Adrian Bunk <bunk@stusta.de>]

On Thu, Nov 10, 2005 at 12:11:23AM +0100, Willy Tarreau wrote:
> Hi Adrian, hi Marcelo,
> 
> On Wed, Nov 09, 2005 at 12:15:31PM -0200, Marcelo Tosatti wrote:
> (...)
> > > If there will be one more -rc, could you include my airo_cs fix?
> > 
> > Hi Adrian,
> > 
> > I think it can wait for the next -pre... Hope there wont be another -rc.
> 
> So do I. Moreover, -pre should start with several network-related fixes,
> so your fix might find a comfortable place there :-)
> 
> I will release another -hf with recent fixes. I noticed I missed three of
> them from 2.4.32-rc2 (I thought I was up to date but they showed up just
> before the announcement). They are the memleak in sd_mod, the TCP snd_wnd
> fix and the fix for the infinite loop in udp_v6_get_port(). So I can also
> merge your fix early if you want (I already queued it for later inclusion).
> I generally try to avoid including fixes that are not much transversal,
> but I read in your patch that the bug you fixed could cause side effects
> to any parts in the kernel, so if you feel it's appropriate for -hf, I'll
> trust you :-)

I'd say the big advantage of my patch is that although it's hard to see 
the bug it fixes, it's easy to see that it can't break anything.

> Cheers,
> Willy

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed