From: tab@snarc.org (Vincent Hanquez)
To: Zachary Amsden <zach@vmware.com>
Cc: Andrew Morton <akpm@osdl.org>, Chris Wright <chrisw@osdl.org>,
Linus Torvalds <torvalds@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Virtualization Mailing List <virtualization@lists.osdl.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
Martin Bligh <mbligh@mbligh.org>,
Pratap Subrahmanyam <pratap@vmware.com>,
Christopher Li <chrisl@vmware.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 12/21] i386 Deprecate descriptor asm
Date: Thu, 10 Nov 2005 17:14:46 +0100 [thread overview]
Message-ID: <20051110161446.GA13204@snarc.org> (raw)
In-Reply-To: <200511080431.jA84Vdg5009909@zach-dev.vmware.com>
On Mon, Nov 07, 2005 at 08:31:39PM -0800, Zachary Amsden wrote:
> +struct desc_internal_struct {
> + unsigned short limit0;
> + unsigned short base0;
> + unsigned char base1;
> + unsigned char type;
> + unsigned int limit1 : 4;
> + unsigned int flags : 4;
> + unsigned char base2;
> +} __attribute__((packed));
just a minor nit,
wouldn't that be better to use u8 and u16 types here ?
Cheers,
--
Vincent Hanquez
prev parent reply other threads:[~2005-11-10 16:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-08 4:31 [PATCH 12/21] i386 Deprecate descriptor asm Zachary Amsden
2005-11-08 7:31 ` Ingo Molnar
2005-11-10 14:18 ` Andi Kleen
2005-11-10 16:14 ` Vincent Hanquez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051110161446.GA13204@snarc.org \
--to=tab@snarc.org \
--cc=akpm@osdl.org \
--cc=chrisl@vmware.com \
--cc=chrisw@osdl.org \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@mbligh.org \
--cc=mingo@elte.hu \
--cc=pratap@vmware.com \
--cc=torvalds@osdl.org \
--cc=virtualization@lists.osdl.org \
--cc=zach@vmware.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox