public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Con Kolivas <kernel@kolivas.org>
To: Peter Williams <pwil3058@bigpond.net.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Chris Han <xiphux@gmail.com>,
	William Lee Irwin III <wli@holomorphy.com>,
	Jake Moilanen <moilanen@austin.ibm.com>
Subject: [PATCH] plugsched - update Kconfig
Date: Fri, 11 Nov 2005 14:05:33 +1100	[thread overview]
Message-ID: <200511111405.33762.kernel@kolivas.org> (raw)
In-Reply-To: <434F01EA.6060709@bigpond.net.au>

[-- Attachment #1: Type: text/plain, Size: 113 bytes --]

Hi Peter et al

I find the Kconfig menu layout a little confusing and suggest the following 
patch.

Cheers,
Con

[-- Attachment #2: plugsched-6.1.3-update-Kconfig.patch --]
[-- Type: text/x-diff, Size: 4499 bytes --]

Update the Kconfig menu for plugsched

Make the default cpu scheduler choice depend on the presence of that scheduler
being configured in rather than selecting it since the default is for all to
be built in unless manually deselected in the embedded menu.

Make a submenu for spa schedulers instead of having a flat list.

Signed-off-by: Con Kolivas <kernel@kolivas.org>

 Kconfig |   32 ++++++++++++--------------------
 1 files changed, 12 insertions(+), 20 deletions(-)

Index: linux-2.6.14-plugsched/init/Kconfig
===================================================================
--- linux-2.6.14-plugsched.orig/init/Kconfig	2005-11-11 13:35:06.000000000 +1100
+++ linux-2.6.14-plugsched/init/Kconfig	2005-11-11 13:45:25.000000000 +1100
@@ -276,28 +276,28 @@ choice
 
 config CPUSCHED_DEFAULT_INGO
 	bool "Ingosched cpu scheduler"
-	select CPUSCHED_INGO
+	depends on CPUSCHED_INGO
 	---help---
 	  This is the default cpu scheduler which is an O(1) dual priority
 	  array scheduler with a hybrid interactive design.
 
 config CPUSCHED_DEFAULT_STAIRCASE
 	bool "Staircase cpu scheduler"
-	select CPUSCHED_STAIRCASE
+	depends on CPUSCHED_STAIRCASE
 	---help---
 	  This scheduler is an O(1) single priority array with a foreground-
 	  background interactive design.
 
 config CPUSCHED_DEFAULT_SPA_NF
 	bool "Single priority array (SPA) cpu scheduler (no frills)"
-	select CPUSCHED_SPA_NF
+	depends on CPUSCHED_SPA_NF
 	---help---
 	  This is a simple round robin scheduler with a O(1) single priority
 	  array.
 
 config CPUSCHED_DEFAULT_SPA_WS
 	bool "Single priority array (SPA) cpu scheduler (work station)"
-	select CPUSCHED_SPA_WS
+	depends on CPUSCHED_SPA_WS
 	---help---
 	  This is a scheduler with a O(1) single priority array intended for
 	  use on work stations.  It has modifications to improve interactive
@@ -305,7 +305,7 @@ config CPUSCHED_DEFAULT_SPA_WS
 
 config CPUSCHED_DEFAULT_SPA_SVR
 	bool "Single priority array (SPA) cpu scheduler (server)"
-	select CPUSCHED_SPA_SVR
+	depends on CPUSCHED_SPA_SVR
 	---help---
 	  This is a scheduler with a O(1) single priority array intended for
 	  use on server.  It has modifications to reduce CPU delay at moderate
@@ -313,7 +313,7 @@ config CPUSCHED_DEFAULT_SPA_SVR
 
 config CPUSCHED_DEFAULT_ZAPHOD
 	bool "Zaphod cpu scheduler"
-	select CPUSCHED_ZAPHOD
+	depends on CPUSCHED_ZAPHOD
 	---help---
 	  This scheduler is an O(1) single priority array with interactive
 	  bonus, throughput bonus, soft and hard CPU rate caps and a runtime
@@ -322,7 +322,7 @@ config CPUSCHED_DEFAULT_ZAPHOD
 
 config CPUSCHED_DEFAULT_NICK
 	bool "Nicksched cpu scheduler"
-	select CPUSCHED_NICK
+	depends on CPUSCHED_NICK
 	---help---
 	  This is the default cpu scheduler which is an O(1) dual priority
 	  array scheduler with a hybrid interactive design as modified by
@@ -358,7 +358,7 @@ config CPUSCHED_STAIRCASE
 	  To boot this cpu scheduler, if it is not the default, use the
 	  bootparam "cpusched=staircase".
 
-config CPUSCHED_SPA
+menuconfig CPUSCHED_SPA
 	bool "SPA cpu schedulers" if EMBEDDED
 	depends on PLUGSCHED
 	default y
@@ -366,9 +366,7 @@ config CPUSCHED_SPA
 	  Support for O(1) single priority array schedulers.
 
 config CPUSCHED_SPA_NF
-	bool "SPA cpu scheduler (no frills)" if EMBEDDED
-	depends on PLUGSCHED
-	select CPUSCHED_SPA
+	bool "SPA cpu scheduler (no frills)" if CPUSCHED_SPA
 	default y
 	---help---
 	  This scheduler is a simple round robin O(1) single priority array
@@ -379,9 +377,7 @@ config CPUSCHED_SPA_NF
 	  bootparam "cpusched=spa_no_frills".
 
 config CPUSCHED_SPA_WS
-	bool "SPA cpu scheduler (work station)" if EMBEDDED
-	depends on PLUGSCHED
-	select CPUSCHED_SPA
+	bool "SPA cpu scheduler (work station)" if CPUSCHED_SPA
 	default y
 	---help---
 	  This is a scheduler with a O(1) single priority array intended for
@@ -391,9 +387,7 @@ config CPUSCHED_SPA_WS
 	  bootparam "cpusched=spa_ws".
 
 config CPUSCHED_SPA_SVR
-	bool "SPA cpu scheduler (server)" if EMBEDDED
-	depends on PLUGSCHED
-	select CPUSCHED_SPA
+	bool "SPA cpu scheduler (server)" if CPUSCHED_SPA
 	default y
 	---help---
 	  This is a scheduler with a O(1) single priority array intended for
@@ -403,9 +397,7 @@ config CPUSCHED_SPA_SVR
 	  bootparam "cpusched=spa_svr".
 
 config CPUSCHED_ZAPHOD
-	bool "Zaphod cpu scheduler" if EMBEDDED
-	depends on PLUGSCHED
-	select CPUSCHED_SPA
+	bool "Zaphod cpu scheduler" if CPUSCHED_SPA
 	default y
 	---help---
 	  This scheduler is an O(1) single priority array with interactive

  parent reply	other threads:[~2005-11-11  3:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-14  0:55 [ANNOUNCE][RFC] PlugSched-6.1.3 for 2.6.13 and 2.6.14-rc4 Peter Williams
2005-10-29  2:35 ` Peter Williams
2005-11-07 22:01 ` Peter Williams
2005-11-11  3:00 ` [PATCH] Staircase v13 for plugsched 6.1.3 Con Kolivas
2005-11-13  1:36   ` Peter Williams
2005-11-11  3:05 ` Con Kolivas [this message]
2005-11-11  3:11   ` [PATCH] plugsched - update Kconfig Con Kolivas
2005-11-11  3:17   ` [PATCH] plugsched - update Kconfig-1 Con Kolivas
2005-11-13  1:34     ` Peter Williams
2005-11-13  1:44       ` Con Kolivas
2005-11-13  5:22         ` Peter Williams
2005-11-13  5:37           ` Con Kolivas
2005-11-13  9:10             ` Peter Williams
2005-11-13  9:30               ` Con Kolivas
2005-11-13 22:52                 ` Peter Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200511111405.33762.kernel@kolivas.org \
    --to=kernel@kolivas.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=moilanen@austin.ibm.com \
    --cc=pwil3058@bigpond.net.au \
    --cc=wli@holomorphy.com \
    --cc=xiphux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox