From: Christoph Hellwig <hch@infradead.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: James.Bottomley@SteelEye.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] removed useless SCSI_GENERIC_NCR5380_MMIO
Date: Sat, 12 Nov 2005 07:10:47 +0000 [thread overview]
Message-ID: <20051112071047.GA29051@infradead.org> (raw)
In-Reply-To: <20051112043707.GX5376@stusta.de>
On Sat, Nov 12, 2005 at 05:37:07AM +0100, Adrian Bunk wrote:
> This patch removes the useless SCSI_GENERIC_NCR5380_MMIO.
>
> It's useless, since SCSI_G_NCR5380_MEM != CONFIG_SCSI_G_NCR5380_MEM.
>
> This issue exists at least since kernel 2.6.0 and since it seems noone
> noticed it I'd say we can safely remove it.
NACK. I know at least Alan has hardware and might want to bring it
forward. A better fix would be to convert the generic ncr5380 driver
to use ioread*/iowrite* so it can cover both mmio and pio in a single
binary.
next prev parent reply other threads:[~2005-11-12 7:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-12 4:37 [2.6 patch] removed useless SCSI_GENERIC_NCR5380_MMIO Adrian Bunk
2005-11-12 7:10 ` Christoph Hellwig [this message]
2005-11-12 18:20 ` Alan Cox
2005-11-12 17:57 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051112071047.GA29051@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox