public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Gabriel A. Devenyi" <ace@staticwave.ca>
To: sziwan@users.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: [RESEND] [PATCH] drivers/acpi/asus_acpi.c unsigned comparison
Date: Sat, 12 Nov 2005 16:16:14 -0500	[thread overview]
Message-ID: <200511121616.14940.ace@staticwave.ca> (raw)

It helps if I attach the patch.

proc_write_brn, and proc_write_disp both use a parameter "count" to store the result from parse_arg.
The return of parse_arg is an int, but count is declared as an unsigned int, and later checked versus zero,
which is meaningless. This patch fixes the declaration of count in both functions.

Thanks to LinuxICC (http://linuxicc.sf.net)

Signed-off-by: Gabriel A. Devenyi <ace@staticwave.ca>

diff --git a/drivers/acpi/asus_acpi.c b/drivers/acpi/asus_acpi.c
index fec895a..9dfd0cd 100644
--- a/drivers/acpi/asus_acpi.c
+++ b/drivers/acpi/asus_acpi.c
@@ -748,7 +748,7 @@ proc_read_brn(char *page, char **start, 
 
 static int
 proc_write_brn(struct file *file, const char __user * buffer,
-	       unsigned long count, void *data)
+	       long count, void *data)
 {
 	int value;
 
@@ -798,7 +798,7 @@ proc_read_disp(char *page, char **start,
  */
 static int
 proc_write_disp(struct file *file, const char __user * buffer,
-		unsigned long count, void *data)
+		long count, void *data)
 {
 	int value;
 


-- 
Gabriel A. Devenyi
ace@staticwave.ca

             reply	other threads:[~2005-11-12 21:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-12 21:16 Gabriel A. Devenyi [this message]
2005-11-16 19:52 ` [RESEND] [PATCH] drivers/acpi/asus_acpi.c unsigned comparison Bjorn Helgaas
2005-11-16 20:23   ` ICMP Ping being lost between kernel and the ping program Jesse Gordon
2005-11-17 21:35     ` ICMP Ping being lost between kernel and the ping program. (Solved!) Jesse Gordon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200511121616.14940.ace@staticwave.ca \
    --to=ace@staticwave.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sziwan@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox