public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Neil Brown <neilb@suse.de>
Cc: "J.A. Magallon" <jamagallon@able.es>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: x86 building altivec for raid ?
Date: Sun, 13 Nov 2005 23:12:43 +0100	[thread overview]
Message-ID: <20051113221243.GA7638@mars.ravnborg.org> (raw)
In-Reply-To: <17271.44949.625740.612801@cse.unsw.edu.au>

> 
> diff ./drivers/md/Makefile~current~ ./drivers/md/Makefile
> --- ./drivers/md/Makefile~current~	2005-11-14 08:13:43.000000000 +1100
> +++ ./drivers/md/Makefile	2005-11-14 08:23:29.000000000 +1100
> @@ -8,12 +8,15 @@ dm-multipath-objs := dm-hw-handler.o dm-
>  dm-snapshot-objs := dm-snap.o dm-exception-store.o
>  dm-mirror-objs	:= dm-log.o dm-raid1.o
>  md-mod-objs     := md.o bitmap.o
> +raid6-$(CONFIG_ALTIVEC) :=  \
> +		   raid6altivec1.o raid6altivec2.o raid6altivec4.o \
> +		   raid6altivec8.o
> +raid6-$(CONFIG_X86) :=  raid6mmx.o raid6sse1.o
> +raid6-$(CONFIG_X86_64) := raid6sse2.o
>  raid6-objs	:= raid6main.o raid6algos.o raid6recov.o raid6tables.o \
Change the above line to:
>  raid6-y	+= raid6main.o raid6algos.o raid6recov.o raid6tables.o \

>  		   raid6int1.o raid6int2.o raid6int4.o \
>  		   raid6int8.o raid6int16.o raid6int32.o \
> -		   raid6altivec1.o raid6altivec2.o raid6altivec4.o \
> -		   raid6altivec8.o \
> -		   raid6mmx.o raid6sse1.o raid6sse2.o
> +		   $(raid6-y)
And then you do not need to add the above line.

The Makefile deserve a small comment why you overwrite
the first assigned vaule of raid6-y - otherwise it may confuse when
reading through the file.

	Sam

  parent reply	other threads:[~2005-11-13 22:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-13 21:02 x86 building altivec for raid ? J.A. Magallon
2005-11-13 21:26 ` Neil Brown
2005-11-13 21:35   ` H. Peter Anvin
2005-11-13 21:49   ` J.A. Magallon
2005-11-13 22:12   ` Sam Ravnborg [this message]
2005-11-13 22:33   ` J.A. Magallon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051113221243.GA7638@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=hpa@zytor.com \
    --cc=jamagallon@able.es \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox