Re: [RFT][PATCH 2/3] swsusp: introduce the swap map structure

Pavel Machek
2005-11-13T21:17:05Z

Hi!

> This patch introduces the swap map structure that can be used by swsusp for
> keeping tracks of data pages written to the swap.  The structure itself is
> described in a comment within the patch.
>
> The overall idea is to reduce the amount of metadata written to the swap
> and to write and read the image pages sequentially, in a file-alike way.
> This makes the swap-handling part of swsusp fairly independent of its
> snapshot-handling part and will hopefully allow us to completely
> separate these two parts in the future.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

ACK.

> +struct swap_map_handle {
> + void *tfm; /* Needed for the encryption */
> + struct swap_map_page *cur;
> + unsigned int k;
> +};

I thought you killed encryption in 1/3?

> @@ -33,6 +33,9 @@
>
> #include "power.h"
>
> +struct pbe *pagedir_nosave = NULL;
> +unsigned int nr_copy_pages = 0;
> +
> #ifdef CONFIG_HIGHMEM
> struct highmem_page {
> char *data;

You don't need to initialize to zero/NULL.

Pavel
--
Thanks, Sharp!