public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Neil Brown <neilb@suse.de>
Cc: Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org>,
	vojtech@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: uinput broken in 2.6.15-rc1
Date: Mon, 14 Nov 2005 01:10:04 -0500	[thread overview]
Message-ID: <200511140110.05991.dtor_core@ameritech.net> (raw)
In-Reply-To: <17272.7295.464735.805122@cse.unsw.edu.au>

On Monday 14 November 2005 00:11, Neil Brown wrote:
> 
> The 'uinput' driver doesn't work well in 2.6.15-rc1.  It
> triggers this complaint:
> 		printk(KERN_WARNING "input: device %s is statically allocated, will not register\n"
> 			"Please convert to input_allocate_device() or contact dtor_core@ameritech.net\n",
> 			dev->name ? dev->name : "<Unknown>");
> 
> The following patch fixes it for me, but I'm not convinced it is
> correct.  I would expect it to need a special 'free' routine to match
> the special 'alloc' routine, but I couldn't easily find one.
> 

Hi,

This should work OK as long as you don't try to reuse the uinput device
because input_unregister_device frees the data structure for you and
uinput does not expect to lose part of its data structure.

I am trying to comer up with a proper fix...

-- 
Dmitry

      reply	other threads:[~2005-11-14  6:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-14  5:11 uinput broken in 2.6.15-rc1 Neil Brown
2005-11-14  6:10 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200511140110.05991.dtor_core@ameritech.net \
    --to=dtor_core@ameritech.net \
    --cc=aris@cathedrallabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox