Re: Nick's core remove PageReserved broke vmware...

[Gleb Natapov <gleb@minantech.com>]

On Mon, Nov 14, 2005 at 04:52:52PM +0200, Michael S. Tsirkin wrote:
> Index: linux-2.6.14-dontcopy/mm/madvise.c
> ===================================================================
> --- linux-2.6.14-dontcopy.orig/mm/madvise.c	2005-10-28 02:02:08.000000000 +0200
> +++ linux-2.6.14-dontcopy/mm/madvise.c	2005-11-14 17:04:51.000000000 +0200
> @@ -22,14 +22,20 @@ static long madvise_behavior(struct vm_a
>  	struct mm_struct * mm = vma->vm_mm;
>  	int error = 0;
>  	pgoff_t pgoff;
> -	int new_flags = vma->vm_flags & ~VM_READHINTMASK;
> +	int new_flags = vma->vm_flags;
>  
>  	switch (behavior) {
>  	case MADV_SEQUENTIAL:
> -		new_flags |= VM_SEQ_READ;
> +		new_flags = (new_flags & ~VM_RAND_READ) | VM_SEQ_READ;
>  		break;
>  	case MADV_RANDOM:
> -		new_flags |= VM_RAND_READ;
> +		new_flags = (new_flags & ~VM_SEQ_READ) | VM_RAND_READ;
> +		break;
> +	case MADV_DONTFORK:
> +		new_flags |= VM_DONTFORK;
> +		break;
> +	case MADV_DOFORK:
> +		new_flags &= ~VM_DONTFORK;
>  		break;
>  	default:
>  		break;
It seams now you broke MADV_NORMAL.

--
			Gleb.