Re: [2.6 patch] i386: always use 4k stacks

Adrian Bunk
2005-12-18T14:12:06Z

On Sun, Dec 18, 2005 at 08:44:56AM -0500, Michael Poole wrote:
> Adrian Bunk writes:
>
> > On Sun, Dec 18, 2005 at 06:57:44AM +0100, Bodo Eggert wrote:
> > >
> > > Would you run a desktop with an nfs server on xfs on lvm on dm on SCSI?
> > > Or a productive server on -mm?
> > >
> > > IMO it's OK to push 4K stacks in -mm, but one week of no error reports from
> > > a few testers don't make a reliable system.
> > > [...]
> >
> > It isn't that 4k stacks were completely untested.
> >
> > Fedore enables it for a long time.
> >
> > Even RHEL4 always uses 4k stacks - and RHEL is a distribution many
> > people use on their production servers.
>
> As was pointed out previously in this thread, at least one
> configuration that is known to have problems with 4k stacks is simply
> not supported by RHEL. How many more are like that?

s/is known/was known/

XFS got fixed and Neil's patch should fix the rest of the problem.

My count of bug reports for problems with 4k stacks after Neil's patch
went into -mm is still at 0.

4k stacks are always used by Fedora.
4k stacks are always used by RHEL4.

Granted, there might be some small areas that are not covered by such
distributions.

You ask "How many more are like that?".
That's exactly the question I want answers for by always enabling it
in -mm.

-mm is a pretty experimental kernel and everything using it knows about
this. Many -mm kernels contain more than hundred new patches compared to
the previous -mm kernel, and some of these patches are of the quality
"compiles with some specific options set and might not always crash your
kernel". A patch like always enabling 4k stacks that is essentially
already used by at least one popular desktop distribution (Fedora) and
at least one popular server distriution (RHEL4) already had _far_ more
than the average testing coverage for patches in -mm, so WTF is the
problem?

> Michael Poole

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed