From: Christoph Hellwig <hch@lst.de>
To: Greg Ungerer <gerg@snapgear.com>
Cc: Christoph Hellwig <hch@lst.de>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68knommu: enable_irq/disable_irq
Date: Tue, 15 Nov 2005 09:48:00 +0100 [thread overview]
Message-ID: <20051115084800.GA1542@lst.de> (raw)
In-Reply-To: <437993A8.8050702@snapgear.com>
On Tue, Nov 15, 2005 at 05:52:08PM +1000, Greg Ungerer wrote:
> Hi Christoph,
>
> Christoph Hellwig wrote:
> >mach_enable_irq/mach_disable_irq are never actually set, so let's remove
> >them.
> >
> >Btw, is it really intentionally that enable_irq/disable_irq are no-ops on
> >m68knommu?
>
> No, I think they should be implemented. It would clean up some driver
> irq ugliness in some of the m68knommu arch specific drivers.
Any chance you could investigate using the kernel/irq/ framework for
m68knommu? It's one of the few architectures not using that code yet.
prev parent reply other threads:[~2005-11-15 8:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-13 7:41 [PATCH] m68knommu: enable_irq/disable_irq Christoph Hellwig
2005-11-15 7:52 ` Greg Ungerer
2005-11-15 8:48 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051115084800.GA1542@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=gerg@snapgear.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox