From: Claudio Scordino <cloud.of.andor@gmail.com>
To: Peter Chubb <peterc@gelato.unsw.edu.au>
Cc: Chris Wright <chrisw@osdl.org>,
dean gaudet <dean-list-linux-kernel@arctic.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
"Magnus Naeslund(f)" <mag@fbab.net>,
"Hua Zhong (hzhong)" <hzhong@cisco.com>,
linux-kernel@vger.kernel.org, kernelnewbies@nl.linux.org,
David Wagner <daw@cs.berkeley.edu>,
Lee Revell <rlrevell@joe-job.com>
Subject: New getrusage
Date: Tue, 15 Nov 2005 18:00:08 +0100 [thread overview]
Message-ID: <200511151800.09279.cloud.of.andor@gmail.com> (raw)
In-Reply-To: <20051112011006.GD7991@shell0.pdx.osdl.net>
Actually, I think that a better implementation of getrusage would be the
following one, but it requires a (new) third parameter. That's why I didn't
suggest it...
Many thanks,
Claudio
Signed-off-by: Claudio Scordino <cloud.of.andor@gmail.com>
asmlinkage long sys_getrusage(int who, struct rusage __user *ru, pid_t pid)
{
struct rusage r;
struct task_struct* tsk = current;
if ((pid < 0) ||
((who != RUSAGE_SELF) && (who != RUSAGE_CHILDREN)))
return -EINVAL;
read_lock(&tasklist_lock);
if (pid > 0) {
tsk = find_task_by_pid(pid);
if (tsk == NULL)
goto bad;
if (((current->uid != tsk->euid) ||
(current->uid != tsk->suid) ||
(current->uid != tsk->uid) ||
(current->gid != tsk->egid) ||
(current->gid != tsk->sgid) ||
(current->gid != tsk->gid)) && !capable(CAP_SYS_PTRACE))
goto bad;
}
k_getrusage(tsk, who, &r);
read_unlock(&tasklist_lock);
return copy_to_user(ru, &r, sizeof(r)) ? -EFAULT : 0;
bad:
read_unlock(&tasklist_lock);
return tsk ? -EPERM : -EINVAL;
}
next prev parent reply other threads:[~2005-11-15 17:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-10 23:47 [PATCH] getrusage sucks Hua Zhong (hzhong)
2005-11-11 0:23 ` Claudio Scordino
2005-11-11 0:32 ` Magnus Naeslund(f)
2005-11-11 1:11 ` Claudio Scordino
2005-11-11 13:30 ` Alan Cox
2005-11-11 22:38 ` Claudio Scordino
2005-11-11 23:23 ` Alan Cox
2005-11-11 23:02 ` Chris Wright
2005-11-11 23:44 ` David Wagner
2005-11-12 0:53 ` Chris Wright
2005-11-12 6:37 ` David Wagner
2005-11-11 23:58 ` Alan Cox
2005-11-11 23:43 ` Claudio Scordino
2005-11-11 23:49 ` dean gaudet
2005-11-12 1:10 ` Chris Wright
2005-11-12 15:10 ` making makefile for 2.6 kernel anil dahiya
2005-11-12 15:16 ` anil dahiya
2005-11-12 22:19 ` Sam Ravnborg
2005-11-13 1:34 ` [PATCH] getrusage sucks Claudio Scordino
2005-11-15 16:56 ` Claudio Scordino
2005-11-15 17:00 ` Claudio Scordino [this message]
2005-11-11 23:08 ` Claudio Scordino
2005-11-11 23:41 ` David Wagner
2005-11-15 1:08 ` Peter Chubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200511151800.09279.cloud.of.andor@gmail.com \
--to=cloud.of.andor@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=chrisw@osdl.org \
--cc=daw@cs.berkeley.edu \
--cc=dean-list-linux-kernel@arctic.org \
--cc=hzhong@cisco.com \
--cc=kernelnewbies@nl.linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mag@fbab.net \
--cc=peterc@gelato.unsw.edu.au \
--cc=rlrevell@joe-job.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox