public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Cal Peake <cp@absolutedigital.net>
Cc: linux-kernel@vger.kernel.org, jcm@jonmasters.org,
	torvalds@osdl.org, viro@ftp.linux.org.uk, hch@lst.de
Subject: Re: floppy regression from "[PATCH] fix floppy.c to store correct ..."
Date: Wed, 16 Nov 2005 00:59:58 -0800	[thread overview]
Message-ID: <20051116005958.25adcd4a.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0511160034320.988@lancer.cnet.absolutedigital.net>

Cal Peake <cp@absolutedigital.net> wrote:
>
> Hi,
> 
> Commit 88baf3e85af72f606363a85e9a60e9e61cc64a6c:
> 
>  "[PATCH] fix floppy.c to store correct ro/rw status in underlying gendisk"
> 
> causes an annoying side-effect. Upon first write attempt to a floppy I get 
> this:
> 
> $ dd if=bootdisk.img of=/dev/fd0 bs=1440k
> dd: writing `/dev/fd0': Operation not permitted
> 1+0 records in
> 0+0 records out
> 
> Any successive attempts succeed without problem. Confirmed that backing 
> out the patch fixes it.
> 

hmm, yes, when floppy_open() does its test we haven't yet gone and
determined the state of FD_DISK_WRITABLE.  On later opens, we have done, so
things work OK.

We may be able to do the test at the end of floppy_open(), after
check_disk_change() has called floppy_revalidate().  But for O_NDELAY opens
we appear to be screwed.

  reply	other threads:[~2005-11-16  9:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-16  5:47 floppy regression from "[PATCH] fix floppy.c to store correct ..." Cal Peake
2005-11-16  8:59 ` Andrew Morton [this message]
2005-11-16 11:22   ` Jon Masters
2005-11-19  3:44   ` Jon Masters
2005-11-21  3:36     ` Cal Peake
2005-11-21 11:59       ` Jon Masters
2005-11-22  3:15     ` Linus Torvalds
2005-11-22  4:21       ` Jon Masters
2005-11-22  7:31     ` Andrew Morton
2005-11-22 11:56       ` Jon Masters
2005-11-22 22:16         ` Andrew Morton
2005-11-23  4:47           ` Jon Masters
2005-11-28 18:37           ` Bill Davidsen
2005-11-28 20:33             ` Jon Masters
2005-11-29 22:00               ` Bill Davidsen
2005-11-30  1:15                 ` Jon Masters
2005-11-16 10:50 ` Mikael Pettersson
     [not found] <59olg-7rC-3@gated-at.bofh.it>
     [not found] ` <59rsT-3Co-27@gated-at.bofh.it>
     [not found]   ` <5arTK-5Wu-1@gated-at.bofh.it>
     [not found]     ` <5bAW4-8wm-19@gated-at.bofh.it>
     [not found]       ` <5bEYO-6oH-15@gated-at.bofh.it>
     [not found]         ` <5bOEG-5jk-19@gated-at.bofh.it>
     [not found]           ` <5bUK2-61i-5@gated-at.bofh.it>
2005-11-23 17:39             ` Bodo Eggert
2005-11-23 18:02               ` Jon Masters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051116005958.25adcd4a.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=cp@absolutedigital.net \
    --cc=hch@lst.de \
    --cc=jcm@jonmasters.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox