From: Al Viro <viro@ftp.linux.org.uk>
To: Linus Torvalds <torvalds@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] isaectomy: toshiba.c
Date: Wed, 16 Nov 2005 04:09:39 +0000 [thread overview]
Message-ID: <20051116040939.GB27946@ftp.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0511151959270.13959@g5.osdl.org>
On Tue, Nov 15, 2005 at 08:03:19PM -0800, Linus Torvalds wrote:
> Hmm.. I actually believe that the isa_read() functions are more portable
> and easier to use than ioremap().
>
> The reason? A platform will always know where any legacy ISA bus resides,
> while the "ioremap()" thing will depend on platform PCI code to have set
> the right offsets (and thus the resource addresses) for whatever bus the
> PCI device is on.
>
> So doing a "ioremap(0xf0000)" is actually a harder operation at run-time
> when you have to basically have some special case ("is this address range
> in the ISA legacy region") than for the platform code to just always map
> the ISA legacy region at some random offset and then doing "isa_read()"
> from that.
>
> Is there some underlying reason you want to remove the isa_xxx stuff?
The fact that it has almost no users? And nearly all drivers that do
use it (and not just have it in dead code) are using it for access to
very specific locations in BIOS...
prev parent reply other threads:[~2005-11-16 4:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-16 3:50 [PATCH 1/8] isaectomy: toshiba.c Al Viro
2005-11-16 4:03 ` Linus Torvalds
2005-11-16 4:09 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051116040939.GB27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox