public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Andrew Morton <akpm@osdl.org>
Cc: paulus@samba.org, linuxppc64-dev@ozlabs.org,
	linux-kernel@vger.kernel.org, mnutter@us.ibm.com
Subject: [PATCH] spufs: Make all exports GPL-only
Date: Wed, 16 Nov 2005 15:26:40 +0100	[thread overview]
Message-ID: <200511161526.42655.arnd@arndb.de> (raw)
In-Reply-To: <20051115174145.70f37501.akpm@osdl.org>

This changes all exported symbols of spufs to EXPORT_SYMBOL_GPL.
The spu_ibox_read/spu_wbox_write symbols are not exported
any more when the scheduler patch is applied.

Signed-off-by: Arnd Bergmann <arndb@de.ibm.com>

---

On Middeweken 16 November 2005 02:41, Andrew Morton wrote:
> +EXPORT_SYMBOL_GPL(hash_page);
> +EXPORT_SYMBOL(spu_alloc);
> +EXPORT_SYMBOL(spu_free);
> +EXPORT_SYMBOL(spu_run);
> +EXPORT_SYMBOL(spu_ibox_read);
> +EXPORT_SYMBOL(spu_wbox_write);
> +EXPORT_SYMBOL_GPL(register_spu_syscalls);
> +EXPORT_SYMBOL_GPL(unregister_spu_syscalls);
> -EXPORT_SYMBOL_GPL(__handle_mm_fault); /* For MOL */
> +EXPORT_SYMBOL_GPL(__handle_mm_fault);
> 
> A strange mixture of GPL and non-GPL.   What's the thinking here?

Lack of thinking ;-)
At first, I had everything as EXPORT_SYMBOL. Everything that was added
in the last few months was EXPORT_SYMBOL_GPL.

Index: linux-2.6.15-rc/arch/powerpc/platforms/cell/spu_base.c
===================================================================
--- linux-2.6.15-rc.orig/arch/powerpc/platforms/cell/spu_base.c
+++ linux-2.6.15-rc/arch/powerpc/platforms/cell/spu_base.c
@@ -399,7 +399,7 @@ struct spu *spu_alloc(void)
 
 	return spu;
 }
-EXPORT_SYMBOL(spu_alloc);
+EXPORT_SYMBOL_GPL(spu_alloc);
 
 void spu_free(struct spu *spu)
 {
@@ -407,7 +407,7 @@ void spu_free(struct spu *spu)
 	list_add_tail(&spu->list, &spu_list);
 	up(&spu_mutex);
 }
-EXPORT_SYMBOL(spu_free);
+EXPORT_SYMBOL_GPL(spu_free);
 
 static int spu_handle_mm_fault(struct spu *spu)
 {
@@ -576,7 +576,7 @@ int spu_run(struct spu *spu)
 
 	return ret;
 }
-EXPORT_SYMBOL(spu_run);
+EXPORT_SYMBOL_GPL(spu_run);
 
 static void __iomem * __init map_spe_prop(struct device_node *n,
 						 const char *name)


  reply	other threads:[~2005-11-16 14:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-15 20:53 [PATCH 0/5] SPU file system for 2.6.15-rc-mm Arnd Bergmann
2005-11-15 20:53 ` [PATCH 2/5] spufs: switchable spu contexts Arnd Bergmann
2005-11-15 20:53 ` [PATCH 3/5] kernel-side context switch code for spufs Arnd Bergmann
2005-11-15 20:53 ` [PATCH 4/5] spufs: add spu-side context switch code Arnd Bergmann
2005-11-15 20:53 ` [PATCH 5/5] spufs: cooperative scheduler support Arnd Bergmann
     [not found] ` <20051115210408.327453000@localhost>
2005-11-16  1:41   ` [PATCH 1/5] spufs: The SPU file system, base Andrew Morton
2005-11-16 14:26     ` Arnd Bergmann [this message]
2005-11-16  5:15   ` Paul Mackerras
2005-11-16  5:26     ` Andrew Morton
2005-11-16 14:38       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200511161526.42655.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc64-dev@ozlabs.org \
    --cc=mnutter@us.ibm.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox