Re: [2.6 patch] PPC_PREP: remove unneeded exports

Benjamin Herrenschmidt
2005-11-13T03:28:34Z

On Sun, 2005-11-13 at 02:26 +0100, Adrian Bunk wrote:
> On Sun, Nov 13, 2005 at 09:31:06AM +1100, Benjamin Herrenschmidt wrote:
> >
> > > ucSystemType is a variable that is EXPORT_SYMBOL'ed but never used in
> > > any way.
> > >
> > > _prep_type is a variable that is needlessly EXPORT_SYMBOL'ed.
> >
> > Therse are old PREP stuffs
> >...
>
> Is the patch below OK?

The ucXXX variables should probably go (or at least be unexported) but I
would keep the _prep_type export for now, unless we are certain no
driver and no out of tree stuff neither uses it (hrm... might well be
the case).

In any case, the proper fix is probably to move the EXPORT_SYMBOL() out
of ppc_ksyms, and have it next to the declaration of the variable.

Ben.