Re: [PATCH 07/11] unpaged: COW on VM_UNPAGED

Dave Jones
2005-11-18T21:08:36Z

On Fri, Nov 18, 2005 at 08:02:02AM +0000, Hugh Dickins wrote:

> No, that was not too hasty: we all agreed that the case _ought_ not to
> arise, and we hadn't worked out the right code to handle it if it did
> arise. What was disappointing is that nobody hit the warnings while
> it was in -mm, but only when it hit Linus' tree.

It was found quite quickly though. Fedora rawhide tracks Linus'
-git trees on an almost daily basis, and this change blew up
the installer, so it wasn't hard to reproduce :)

ddcprobe isn't something that a lot of people run on a daily basis
(probably just the installer people, and they never see -mm kernels),
but I'm surprised that vbetool didn't get spotted when it was in -mm,
as more and more people seem to be trying out suspend/resume these days.

Maybe suspend was busted for some other reason at the time it
was in -mm, so people never got that far ?

Dave