From: Christoph Hellwig <hch@lst.de>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>,
wein@de.ibm.com, Horst.Hummel@de.ibm.com, akpm@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] add compat_ioctl methods to dasd
Date: Thu, 17 Nov 2005 23:18:25 +0100 [thread overview]
Message-ID: <20051117221825.GA26057@lst.de> (raw)
In-Reply-To: <1132230452.5463.10.camel@localhost.localdomain>
On Thu, Nov 17, 2005 at 01:27:32PM +0100, Martin Schwidefsky wrote:
> blkdev_ioctl is explicitly called with a NULL file pointer. That can't
> work with block device drivers that use unlocked ioctls. We'd need to
> create a struct file with at least a valid f_dentry->d_inode->i_bdev
> chain in ioctl_by_bdev to make it work with unlocked ioctls. Not nice ..
Yes, you're right. Looks like we finally need to do the long-planned
sanitizing of the blkdev ioctl interface first.
Let's drop the patch for now.
prev parent reply other threads:[~2005-11-17 22:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-04 22:16 [PATCH 1/4] add compat_ioctl methods to dasd Christoph Hellwig
2005-11-12 9:33 ` Christoph Hellwig
2005-11-15 14:51 ` Martin Schwidefsky
2005-11-15 17:24 ` Christoph Hellwig
2005-11-16 8:45 ` Christoph Hellwig
2005-11-17 12:27 ` Martin Schwidefsky
2005-11-17 22:18 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051117221825.GA26057@lst.de \
--to=hch@lst.de \
--cc=Horst.Hummel@de.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=wein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox