Re: [PATCH 1/4] add compat_ioctl methods to dasd

Christoph Hellwig
2005-11-17T22:18:43Z

On Thu, Nov 17, 2005 at 01:27:32PM +0100, Martin Schwidefsky wrote:
> blkdev_ioctl is explicitly called with a NULL file pointer. That can't
> work with block device drivers that use unlocked ioctls. We'd need to
> create a struct file with at least a valid f_dentry->d_inode->i_bdev
> chain in ioctl_by_bdev to make it work with unlocked ioctls. Not nice ..

Yes, you're right. Looks like we finally need to do the long-planned
sanitizing of the blkdev ioctl interface first.

Let's drop the patch for now.