From: Greg KH <gregkh@suse.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [linux-usb-devel] [PATCH 02/02] USB: add dynamic id functionality to USB core
Date: Thu, 17 Nov 2005 17:09:32 -0800 [thread overview]
Message-ID: <20051118010932.GA11514@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0511171219040.5089-100000@iolanthe.rowland.org>
On Thu, Nov 17, 2005 at 12:19:43PM -0500, Alan Stern wrote:
> On Thu, 17 Nov 2005, Greg KH wrote:
>
> > > > + fields = sscanf(buf, "%x %x", &idVendor, &idProduct);
> > > > + if (fields < 0)
> > > > + return -EINVAL;
> > >
> > > Don't you want to test (fields < 2)?
> >
> > No, it's ok to just specify the vendor, if you want a product of 0 :)
> >
> > PCI does it this way too.
>
> Well, in that case shouldn't you test (fields < 1)?
Yeah, good point. I've also changed it to be < 2, as it doesn't really
make sense to have a product number of 0.
thanks,
greg k-h
next prev parent reply other threads:[~2005-11-18 1:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-17 0:30 [PATCH 00/02] [RFC] Add dynamic id support to all USB drivers Greg KH
2005-11-17 0:31 ` [PATCH 01/02] USB: reorg some functions out of the main usb.c file Greg KH
2005-11-17 0:32 ` [PATCH 02/02] USB: add dynamic id functionality to USB core Greg KH
2005-11-17 15:55 ` [linux-usb-devel] " Alan Stern
2005-11-17 16:25 ` Greg KH
2005-11-17 17:19 ` Alan Stern
2005-11-18 1:09 ` Greg KH [this message]
2005-11-17 19:58 ` Ingo Oeser
2005-11-18 1:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051118010932.GA11514@suse.de \
--to=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox