From: Adrian Bunk <bunk@stusta.de>
To: Dave Jones <davej@redhat.com>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Cc: rusty@rustcorp.com.au, dwmw2@infradead.org,
linux-mtd@lists.infradead.org
Subject: [2.6 patch] build kernel/intermodule.c only when required
Date: Fri, 18 Nov 2005 04:37:02 +0100 [thread overview]
Message-ID: <20051118033702.GY11494@stusta.de> (raw)
In-Reply-To: <20051118031751.GA2773@redhat.com>
On Thu, Nov 17, 2005 at 10:17:51PM -0500, Dave Jones wrote:
> On Thu, Nov 17, 2005 at 06:55:29PM -0800, Andrew Morton wrote:
>
> > > IMHO the warnings are the best solution for getting a vast amount fixed,
> > > and then it's time to think about the rest.
> >
> > But the warnings don't *work*. I'm *still* staring at stupid pm_register
> > and intermodule_foo warnings. How long has that been?
>
> Too long. I think the mtd stuff won't ever get fixed until after that
> function gets removed.
Let's limit the inclusion of kernel/intermodule.c to the users of these
drivers.
> Dave
cu
Adrian
<-- snip -->
Let's build kernel/intermodule.c only when required.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/mtd/chips/Kconfig | 1 +
drivers/mtd/devices/Kconfig | 1 +
init/Kconfig | 3 +++
kernel/Makefile | 3 ++-
4 files changed, 7 insertions(+), 1 deletion(-)
--- linux-2.6.15-rc1-mm1-full/init/Kconfig.old 2005-11-18 03:22:53.000000000 +0100
+++ linux-2.6.15-rc1-mm1-full/init/Kconfig 2005-11-18 03:23:29.000000000 +0100
@@ -456,6 +456,9 @@
default !SLAB
bool
+config OBSOLETE_INTERMODULE
+ tristate
+
menu "Loadable module support"
config MODULES
--- linux-2.6.15-rc1-mm1-full/kernel/Makefile.old 2005-11-18 03:21:55.000000000 +0100
+++ linux-2.6.15-rc1-mm1-full/kernel/Makefile 2005-11-18 03:22:35.000000000 +0100
@@ -6,10 +6,11 @@
exit.o itimer.o time.o softirq.o resource.o \
sysctl.o capability.o ptrace.o timer.o user.o \
signal.o sys.o kmod.o workqueue.o pid.o \
- rcupdate.o intermodule.o extable.o params.o posix-timers.o \
+ rcupdate.o extable.o params.o posix-timers.o \
kthread.o wait.o kfifo.o sys_ni.o posix-cpu-timers.o \
ktimers.o
+obj-$(CONFIG_OBSOLETE_INTERMODULE) += intermodule.o
obj-$(CONFIG_FUTEX) += futex.o
obj-$(CONFIG_GENERIC_ISA_DMA) += dma.o
obj-$(CONFIG_SMP) += cpu.o spinlock.o
--- linux-2.6.15-rc1-mm1-full/drivers/mtd/chips/Kconfig.old 2005-11-18 03:23:52.000000000 +0100
+++ linux-2.6.15-rc1-mm1-full/drivers/mtd/chips/Kconfig 2005-11-18 03:28:09.000000000 +0100
@@ -31,6 +31,7 @@
config MTD_GEN_PROBE
tristate
+ select OBSOLETE_INTERMODULE
config MTD_CFI_ADV_OPTIONS
bool "Flash chip driver advanced configuration options"
--- linux-2.6.15-rc1-mm1-full/drivers/mtd/devices/Kconfig.old 2005-11-18 03:25:17.000000000 +0100
+++ linux-2.6.15-rc1-mm1-full/drivers/mtd/devices/Kconfig 2005-11-18 03:27:46.000000000 +0100
@@ -202,6 +202,7 @@
config MTD_DOCPROBE
tristate
select MTD_DOCECC
+ select OBSOLETE_INTERMODULE
config MTD_DOCECC
tristate
next prev parent reply other threads:[~2005-11-18 3:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-18 1:40 [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386 Adrian Bunk
2005-11-18 1:50 ` Andrew Morton
2005-11-18 2:06 ` Adrian Bunk
2005-11-18 2:20 ` Andrew Morton
2005-11-18 2:44 ` Adrian Bunk
2005-11-18 2:55 ` Andrew Morton
2005-11-18 3:17 ` Dave Jones
2005-11-18 3:37 ` Adrian Bunk [this message]
2005-11-18 3:42 ` David S. Miller
2005-11-18 4:03 ` Andrew Morton
2005-11-18 4:11 ` Dave Jones
2005-11-19 0:34 ` Sam Ravnborg
2005-11-19 0:39 ` Dave Jones
2005-11-19 1:19 ` David S. Miller
2005-11-19 20:44 ` Adrian Bunk
2005-11-19 20:51 ` Adrian Bunk
2005-11-19 21:01 ` Sam Ravnborg
2005-11-20 23:27 ` Pavel Machek
2005-11-21 4:27 ` David S. Miller
2005-11-19 13:44 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051118033702.GY11494@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox