Re: maxcpus=1 broken, ACPI bug?

[Maneesh Soni <maneesh@in.ibm.com>]

On Thu, Nov 17, 2005 at 11:54:32AM -0800, Linus Torvalds wrote:
> 
> 
> On Thu, 17 Nov 2005, Maneesh Soni wrote:
> > 
> > Using maxcpus=1 boot option, hangs the system while booting. It was
> > working till 2.6.13-rc2. After git bisect I found that after backing
> > out this ACPI patch it works again, though I had to manually sort the
> > reject while backing out.
> > 
> > http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=acf05f4b7f558051ea0028e8e617144123650272
> 
> Hmm. That patch had a totally idiotic thinko in it (look at the for-loop 
> in acpi_processor_get_power_info_default() and notice how it doesn't 
> actually change anything in the loop).
> 
> That thinko was later fixed (albeit in a really stupid way, and the same 
> cut-and-paste bug still exists in acpi_processor_get_power_info_fadt()).
> 
> Anyway, can you test this diff? It
> 
>  (a) removes the insane (and in one case incorrect) memset loop
>  (b) makes the code that sets "pr->flags.power = 1" match the comment and 
>      the previous behaviour.
> 
> Does that make a difference?
> 

Yes, it works now. I just have to remove the declaration of "i" at
both the places to avoid compiler warnings.

Thanks a lot..
Maneesh

-- 
Maneesh Soni
Linux Technology Center, 
IBM India Software Labs,
Bangalore, India
email: maneesh@in.ibm.com
Phone: 91-80-25044990