From: Vivek Goyal <vgoyal@in.ibm.com>
To: Morton Andrew Morton <akpm@osdl.org>,
linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: [PATCH] Kdump: powerpc and s390 build failure fix
Date: Fri, 18 Nov 2005 18:02:56 +0530 [thread overview]
Message-ID: <20051118123256.GE7217@in.ibm.com> (raw)
Hi Andrew,
I realized that my recent kdump postings will break powerpc and s390 build if
CONFIG_KEXEC=y. Attached is the patch to fix it. Patch is diffed against
2.6.15-rc1-mm2.
Thanks
Vivek
o crash_setup_regs() is an architecture dependent function which is called
in architecture independent section. So every architecture supporting
kexec should at least provide a dummy definition of crash_setup_regs() even
if crash dumping is not implemented yet, to avoid build failures.
Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
---
linux-2.6.15-rc1-mm2-1M-root/include/asm-powerpc/kexec.h | 6 ++++++
linux-2.6.15-rc1-mm2-1M-root/include/asm-s390/kexec.h | 4 ++++
2 files changed, 10 insertions(+)
diff -puN include/asm-powerpc/kexec.h~kdump-powerpc-s390-build-breakage-fix include/asm-powerpc/kexec.h
--- linux-2.6.15-rc1-mm2-1M/include/asm-powerpc/kexec.h~kdump-powerpc-s390-build-breakage-fix 2005-11-18 16:08:31.000000000 +0530
+++ linux-2.6.15-rc1-mm2-1M-root/include/asm-powerpc/kexec.h 2005-11-18 16:08:31.000000000 +0530
@@ -43,5 +43,11 @@ struct kimage;
extern void machine_kexec_simple(struct kimage *image);
#endif
+/*
+ * Provide a dummy definition to avoid build failures. Will remain
+ * empty till crash dump support is enabled.
+ */
+static inline void crash_setup_regs(struct pt_regs *newregs,
+ struct pt_regs *oldregs) { }
#endif /* ! __ASSEMBLY__ */
#endif /* _ASM_POWERPC_KEXEC_H */
diff -puN include/asm-s390/kexec.h~kdump-powerpc-s390-build-breakage-fix include/asm-s390/kexec.h
--- linux-2.6.15-rc1-mm2-1M/include/asm-s390/kexec.h~kdump-powerpc-s390-build-breakage-fix 2005-11-18 16:08:31.000000000 +0530
+++ linux-2.6.15-rc1-mm2-1M-root/include/asm-s390/kexec.h 2005-11-18 16:08:31.000000000 +0530
@@ -36,4 +36,8 @@
#define MAX_NOTE_BYTES 1024
+/* Provide a dummy definition to avoid build failures. */
+static inline void crash_setup_regs(struct pt_regs *newregs,
+ struct pt_regs *oldregs) { }
+
#endif /*_S390_KEXEC_H */
_
reply other threads:[~2005-11-18 12:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051118123256.GE7217@in.ibm.com \
--to=vgoyal@in.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox