* [PATCH] Kdump: powerpc and s390 build failure fix
@ 2005-11-18 12:32 Vivek Goyal
0 siblings, 0 replies; only message in thread
From: Vivek Goyal @ 2005-11-18 12:32 UTC (permalink / raw)
To: Morton Andrew Morton, linux kernel mailing list
Hi Andrew,
I realized that my recent kdump postings will break powerpc and s390 build if
CONFIG_KEXEC=y. Attached is the patch to fix it. Patch is diffed against
2.6.15-rc1-mm2.
Thanks
Vivek
o crash_setup_regs() is an architecture dependent function which is called
in architecture independent section. So every architecture supporting
kexec should at least provide a dummy definition of crash_setup_regs() even
if crash dumping is not implemented yet, to avoid build failures.
Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
---
linux-2.6.15-rc1-mm2-1M-root/include/asm-powerpc/kexec.h | 6 ++++++
linux-2.6.15-rc1-mm2-1M-root/include/asm-s390/kexec.h | 4 ++++
2 files changed, 10 insertions(+)
diff -puN include/asm-powerpc/kexec.h~kdump-powerpc-s390-build-breakage-fix include/asm-powerpc/kexec.h
--- linux-2.6.15-rc1-mm2-1M/include/asm-powerpc/kexec.h~kdump-powerpc-s390-build-breakage-fix 2005-11-18 16:08:31.000000000 +0530
+++ linux-2.6.15-rc1-mm2-1M-root/include/asm-powerpc/kexec.h 2005-11-18 16:08:31.000000000 +0530
@@ -43,5 +43,11 @@ struct kimage;
extern void machine_kexec_simple(struct kimage *image);
#endif
+/*
+ * Provide a dummy definition to avoid build failures. Will remain
+ * empty till crash dump support is enabled.
+ */
+static inline void crash_setup_regs(struct pt_regs *newregs,
+ struct pt_regs *oldregs) { }
#endif /* ! __ASSEMBLY__ */
#endif /* _ASM_POWERPC_KEXEC_H */
diff -puN include/asm-s390/kexec.h~kdump-powerpc-s390-build-breakage-fix include/asm-s390/kexec.h
--- linux-2.6.15-rc1-mm2-1M/include/asm-s390/kexec.h~kdump-powerpc-s390-build-breakage-fix 2005-11-18 16:08:31.000000000 +0530
+++ linux-2.6.15-rc1-mm2-1M-root/include/asm-s390/kexec.h 2005-11-18 16:08:31.000000000 +0530
@@ -36,4 +36,8 @@
#define MAX_NOTE_BYTES 1024
+/* Provide a dummy definition to avoid build failures. */
+static inline void crash_setup_regs(struct pt_regs *newregs,
+ struct pt_regs *oldregs) { }
+
#endif /*_S390_KEXEC_H */
_
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-11-18 12:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-18 12:32 [PATCH] Kdump: powerpc and s390 build failure fix Vivek Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox