dell_rbu driver depends on x86[64]

dell_rbu driver depends on x86[64]

[Dave Jones]

This driver only appears on IA32 & EM64T boxes.

Signed-off-by: Dave Jones <davej@redhat.com>

--- linux-2.6.14/drivers/firmware/Kconfig~	2005-11-14 19:23:45.000000000 -0500
+++ linux-2.6.14/drivers/firmware/Kconfig	2005-11-14 19:24:18.000000000 -0500
@@ -60,6 +60,7 @@ config EFI_PCDP
 
 config DELL_RBU
 	tristate "BIOS update support for DELL systems via sysfs"
+	depends on X86
 	select FW_LOADER
 	help
 	 Say m if you want to have the option of updating the BIOS for your

Re: dell_rbu driver depends on x86[64]

[Andrew Morton]

Dave Jones <davej@redhat.com> wrote:
>
> This driver only appears on IA32 & EM64T boxes.
> 
> Signed-off-by: Dave Jones <davej@redhat.com>
> 
> --- linux-2.6.14/drivers/firmware/Kconfig~	2005-11-14 19:23:45.000000000 -0500
> +++ linux-2.6.14/drivers/firmware/Kconfig	2005-11-14 19:24:18.000000000 -0500
> @@ -60,6 +60,7 @@ config EFI_PCDP
>  
>  config DELL_RBU
>  	tristate "BIOS update support for DELL systems via sysfs"
> +	depends on X86
>  	select FW_LOADER
>  	help
>  	 Say m if you want to have the option of updating the BIOS for your

Does it not compile on other architectures?  If it does, there's an
argument for leaving it there, for compile coverage.

Re: dell_rbu driver depends on x86[64]

[Dave Jones]

On Fri, Nov 18, 2005 at 10:01:44PM -0800, Andrew Morton wrote:
 > Dave Jones <davej@redhat.com> wrote:
 > >
 > > This driver only appears on IA32 & EM64T boxes.
 > > 
 > > Signed-off-by: Dave Jones <davej@redhat.com>
 > > 
 > > --- linux-2.6.14/drivers/firmware/Kconfig~	2005-11-14 19:23:45.000000000 -0500
 > > +++ linux-2.6.14/drivers/firmware/Kconfig	2005-11-14 19:24:18.000000000 -0500
 > > @@ -60,6 +60,7 @@ config EFI_PCDP
 > >  
 > >  config DELL_RBU
 > >  	tristate "BIOS update support for DELL systems via sysfs"
 > > +	depends on X86
 > >  	select FW_LOADER
 > >  	help
 > >  	 Say m if you want to have the option of updating the BIOS for your
 > 
 > Does it not compile on other architectures?  If it does, there's an
 > argument for leaving it there, for compile coverage.

If this were a "only works on non-x86" driver, I'd agree, but
x86 drivers probably get way more coverage than any arch already,
so I don't we really gain much by having this available on
archs that can't run it.

		Dave

Re: dell_rbu driver depends on x86[64]

[Andrew Morton]

Dave Jones <davej@redhat.com> wrote:
>
> On Fri, Nov 18, 2005 at 10:01:44PM -0800, Andrew Morton wrote:
>  > Dave Jones <davej@redhat.com> wrote:
>  > >
>  > > This driver only appears on IA32 & EM64T boxes.
>  > > 
>  > > Signed-off-by: Dave Jones <davej@redhat.com>
>  > > 
>  > > --- linux-2.6.14/drivers/firmware/Kconfig~	2005-11-14 19:23:45.000000000 -0500
>  > > +++ linux-2.6.14/drivers/firmware/Kconfig	2005-11-14 19:24:18.000000000 -0500
>  > > @@ -60,6 +60,7 @@ config EFI_PCDP
>  > >  
>  > >  config DELL_RBU
>  > >  	tristate "BIOS update support for DELL systems via sysfs"
>  > > +	depends on X86
>  > >  	select FW_LOADER
>  > >  	help
>  > >  	 Say m if you want to have the option of updating the BIOS for your
>  > 
>  > Does it not compile on other architectures?  If it does, there's an
>  > argument for leaving it there, for compile coverage.
> 
> If this were a "only works on non-x86" driver, I'd agree, but
> x86 drivers probably get way more coverage than any arch already,
> so I don't we really gain much by having this available on
> archs that can't run it.
> 

Where's the advantage in removing it from non-x86 builds?

Re: dell_rbu driver depends on x86[64]

[Dave Jones]

On Fri, Nov 18, 2005 at 10:17:44PM -0800, Andrew Morton wrote:
 > Dave Jones <davej@redhat.com> wrote:
 > >
 > > On Fri, Nov 18, 2005 at 10:01:44PM -0800, Andrew Morton wrote:
 > >  > Dave Jones <davej@redhat.com> wrote:
 > >  > >
 > >  > > This driver only appears on IA32 & EM64T boxes.
 > >  > > 
 > >  > > Signed-off-by: Dave Jones <davej@redhat.com>
 > >  > > 
 > >  > > --- linux-2.6.14/drivers/firmware/Kconfig~	2005-11-14 19:23:45.000000000 -0500
 > >  > > +++ linux-2.6.14/drivers/firmware/Kconfig	2005-11-14 19:24:18.000000000 -0500
 > >  > > @@ -60,6 +60,7 @@ config EFI_PCDP
 > >  > >  
 > >  > >  config DELL_RBU
 > >  > >  	tristate "BIOS update support for DELL systems via sysfs"
 > >  > > +	depends on X86
 > >  > >  	select FW_LOADER
 > >  > >  	help
 > >  > >  	 Say m if you want to have the option of updating the BIOS for your
 > >  > 
 > >  > Does it not compile on other architectures?  If it does, there's an
 > >  > argument for leaving it there, for compile coverage.
 > > 
 > > If this were a "only works on non-x86" driver, I'd agree, but
 > > x86 drivers probably get way more coverage than any arch already,
 > > so I don't we really gain much by having this available on
 > > archs that can't run it.
 > 
 > Where's the advantage in removing it from non-x86 builds?

One less pointless option showing up in configs.
Just like we don't have countless other arch-specific drivers showing
up under non-native archs. Why is this one different ?

		Dave