* [2.6 patch] drivers/isdn/: add missing #include's
@ 2005-11-19 7:59 Adrian Bunk
2005-11-19 21:12 ` Armin Schindler
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2005-11-19 7:59 UTC (permalink / raw)
To: mac; +Cc: isdn4linux, kkeil, kai.germaschewski, linux-kernel
Every file should #include the headers containing the prototypes for
it's global functions.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/isdn/capi/capifs.c | 2 ++
drivers/isdn/hardware/eicon/os_bri.c | 1 +
drivers/isdn/hardware/eicon/os_pri.c | 1 +
3 files changed, 4 insertions(+)
--- linux-2.6.15-rc1-mm2-full/drivers/isdn/capi/capifs.c.old 2005-11-19 03:41:08.000000000 +0100
+++ linux-2.6.15-rc1-mm2-full/drivers/isdn/capi/capifs.c 2005-11-19 03:41:21.000000000 +0100
@@ -17,6 +17,8 @@
#include <linux/ctype.h>
#include <linux/sched.h> /* current */
+#include "capifs.h"
+
MODULE_DESCRIPTION("CAPI4Linux: /dev/capi/ filesystem");
MODULE_AUTHOR("Carsten Paeth");
MODULE_LICENSE("GPL");
--- linux-2.6.15-rc1-mm2-full/drivers/isdn/hardware/eicon/os_bri.c.old 2005-11-19 03:47:24.000000000 +0100
+++ linux-2.6.15-rc1-mm2-full/drivers/isdn/hardware/eicon/os_bri.c 2005-11-19 03:47:38.000000000 +0100
@@ -16,6 +16,7 @@
#include "diva_pci.h"
#include "mi_pc.h"
#include "pc_maint.h"
+#include "dsrv_bri.h"
/*
** IMPORTS
--- linux-2.6.15-rc1-mm2-full/drivers/isdn/hardware/eicon/os_pri.c.old 2005-11-19 03:49:19.000000000 +0100
+++ linux-2.6.15-rc1-mm2-full/drivers/isdn/hardware/eicon/os_pri.c 2005-11-19 03:49:32.000000000 +0100
@@ -18,6 +18,7 @@
#include "pc_maint.h"
#include "dsp_tst.h"
#include "diva_dma.h"
+#include "dsrv_pri.h"
/* --------------------------------------------------------------------------
OS Dependent part of XDI driver for DIVA PRI Adapter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] drivers/isdn/: add missing #include's
2005-11-19 7:59 [2.6 patch] drivers/isdn/: add missing #include's Adrian Bunk
@ 2005-11-19 21:12 ` Armin Schindler
0 siblings, 0 replies; 2+ messages in thread
From: Armin Schindler @ 2005-11-19 21:12 UTC (permalink / raw)
To: Adrian Bunk; +Cc: isdn4linux, kkeil, Linux Kernel Mailinglist
On Sat, 19 Nov 2005, Adrian Bunk wrote:
> Every file should #include the headers containing the prototypes for
> it's global functions.
Agreed.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Armin Schindler <armin@melware.de>
---
drivers/isdn/capi/capifs.c | 2 ++
drivers/isdn/hardware/eicon/os_bri.c | 1 +
drivers/isdn/hardware/eicon/os_pri.c | 1 +
3 files changed, 4 insertions(+)
--- linux-2.6.15-rc1-mm2-full/drivers/isdn/capi/capifs.c.old 2005-11-19 03:41:08.000000000 +0100
+++ linux-2.6.15-rc1-mm2-full/drivers/isdn/capi/capifs.c 2005-11-19 03:41:21.000000000 +0100
@@ -17,6 +17,8 @@
#include <linux/ctype.h>
#include <linux/sched.h> /* current */
+#include "capifs.h"
+
MODULE_DESCRIPTION("CAPI4Linux: /dev/capi/ filesystem");
MODULE_AUTHOR("Carsten Paeth");
MODULE_LICENSE("GPL");
--- linux-2.6.15-rc1-mm2-full/drivers/isdn/hardware/eicon/os_bri.c.old 2005-11-19 03:47:24.000000000 +0100
+++ linux-2.6.15-rc1-mm2-full/drivers/isdn/hardware/eicon/os_bri.c 2005-11-19 03:47:38.000000000 +0100
@@ -16,6 +16,7 @@
#include "diva_pci.h"
#include "mi_pc.h"
#include "pc_maint.h"
+#include "dsrv_bri.h"
/*
** IMPORTS
--- linux-2.6.15-rc1-mm2-full/drivers/isdn/hardware/eicon/os_pri.c.old 2005-11-19 03:49:19.000000000 +0100
+++ linux-2.6.15-rc1-mm2-full/drivers/isdn/hardware/eicon/os_pri.c 2005-11-19 03:49:32.000000000 +0100
@@ -18,6 +18,7 @@
#include "pc_maint.h"
#include "dsp_tst.h"
#include "diva_dma.h"
+#include "dsrv_pri.h"
/* --------------------------------------------------------------------------
OS Dependent part of XDI driver for DIVA PRI Adapter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-11-19 21:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-19 7:59 [2.6 patch] drivers/isdn/: add missing #include's Adrian Bunk
2005-11-19 21:12 ` Armin Schindler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox