From: Adrian Bunk <bunk@stusta.de>
To: Jody McIntyre <scjody@steamballoon.com>
Cc: bcollins@debian.org, dan@dennedy.org,
linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [2.6 patch] drivers/ieee1394/raw1394.c: fix a NULL pointer dereference
Date: Mon, 21 Nov 2005 00:46:12 +0100 [thread overview]
Message-ID: <20051120234612.GQ16060@stusta.de> (raw)
In-Reply-To: <20051120233351.GA20781@conscoop.ottawa.on.ca>
On Sun, Nov 20, 2005 at 06:33:51PM -0500, Jody McIntyre wrote:
> On Mon, Nov 21, 2005 at 12:20:09AM +0100, Adrian Bunk wrote:
> > + if(cache->filled_head)
> > + kfree(cache->filled_head);
>
> Try again. kfree() of a NULL pointer is perfectly fine.
The problem is that cache is NULL...
> Jody
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2005-11-20 23:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-20 23:20 [2.6 patch] drivers/ieee1394/raw1394.c: fix a NULL pointer dereference Adrian Bunk
2005-11-20 23:33 ` Jody McIntyre
2005-11-20 23:46 ` Adrian Bunk [this message]
2005-11-20 23:54 ` Adrian Bunk
2005-11-20 23:40 ` Dave Jones
2005-11-20 23:52 ` Adrian Bunk
2005-11-21 19:13 ` Stefan Richter
2005-11-21 18:56 ` Ben Collins
2005-11-21 21:52 ` Jody McIntyre
2005-11-21 22:09 ` Stefan Richter
2005-11-21 22:32 ` Jody McIntyre
2005-11-21 21:55 ` Jody McIntyre
2005-11-20 23:45 ` Jesper Juhl
2005-11-20 23:54 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051120234612.GQ16060@stusta.de \
--to=bunk@stusta.de \
--cc=bcollins@debian.org \
--cc=dan@dennedy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=scjody@steamballoon.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox