Re: [linux-dvb-maintainer] [PATCH] Re: bugs in /usr/src/linux/net/ipv6/mcast.c

Johannes Stezenbach
2005-11-20T02:02:04Z

On Thu, Nov 17, 2005 Denis Vlasenko wrote:
> However, a few similar bugs do exist in 2.6!
>
> Patch attached.
>
> Patch intentionally places a comment instead of statement
> in few false positives.
>
> Please review/apply.

Thanks a lot. /me wonders how this could go unnoticed for so long...

Can you add your Signed-off-by: ?

Johannes

> diff -urpN linux-2.6.14.org/drivers/media/dvb/frontends/ves1820.c linux-2.6.14.semicolon_fix/drivers/media/dvb/frontends/ves1820.c
> --- linux-2.6.14.org/drivers/media/dvb/frontends/ves1820.c Sat Nov 5 15:17:30 2005
> +++ linux-2.6.14.semicolon_fix/drivers/media/dvb/frontends/ves1820.c Thu Nov 17 14:41:05 2005
> @@ -140,25 +140,25 @@ static int ves1820_set_symbolrate(struct
> /* yeuch! */
> fpxin = state->config->xin * 10;
> fptmp = fpxin; do_div(fptmp, 123);
> - if (symbolrate < fptmp);
> + if (symbolrate < fptmp)
> SFIL = 1;
> fptmp = fpxin; do_div(fptmp, 160);
> - if (symbolrate < fptmp);
> + if (symbolrate < fptmp)
> SFIL = 0;
> fptmp = fpxin; do_div(fptmp, 246);
> - if (symbolrate < fptmp);
> + if (symbolrate < fptmp)
> SFIL = 1;
> fptmp = fpxin; do_div(fptmp, 320);
> - if (symbolrate < fptmp);
> + if (symbolrate < fptmp)
> SFIL = 0;
> fptmp = fpxin; do_div(fptmp, 492);
> - if (symbolrate < fptmp);
> + if (symbolrate < fptmp)
> SFIL = 1;
> fptmp = fpxin; do_div(fptmp, 640);
> - if (symbolrate < fptmp);
> + if (symbolrate < fptmp)
> SFIL = 0;
> fptmp = fpxin; do_div(fptmp, 984);
> - if (symbolrate < fptmp);
> + if (symbolrate < fptmp)
> SFIL = 1;
>
> fin = state->config->xin >> 4;