Re: bugs in /usr/src/linux/net/ipv6/mcast.c

Denis Vlasenko
2005-11-17T13:46:44Z

On 2.6.14 in drivers/isdn/hisax:

# grep -r '[^a-z0-9_]if *([^()]*([^)]*)[^)]*);' .
./hfc_sx.c: if (Read_hfc(cs, HFCSX_INT_S1));
./hfc_sx.c: if (Read_hfc(cs, HFCSX_INT_S2));
./hfc_sx.c: if (Read_hfc(cs, HFCSX_INT_S1));
./hfc_pci.c: if (Read_hfc(cs, HFCPCI_INT_S1));
./hfc_pci.c: if (Read_hfc(cs, HFCPCI_INT_S1));
./hfc_pci.c: if (Read_hfc(cs, HFCPCI_INT_S1));

These are not bugs, but rather "interesting" coding style:

Write_hfc(cs, HFCSX_INT_M1, cs->hw.hfcsx.int_m1);

/* Clear already pending ints */
if (Read_hfc(cs, HFCSX_INT_S1));

Write_hfc(cs, HFCSX_STATES, HFCSX_LOAD_STATE | 2); /* HFC ST 2 */

Obviously author tried to silence something like lint.
I think it may be replaced with (void)expr; construct.
--
vda