From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932285AbVKUMPF (ORCPT ); Mon, 21 Nov 2005 07:15:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932286AbVKUMPF (ORCPT ); Mon, 21 Nov 2005 07:15:05 -0500 Received: from palinux.external.hp.com ([192.25.206.14]:30599 "EHLO palinux.hppa") by vger.kernel.org with ESMTP id S932285AbVKUMPE (ORCPT ); Mon, 21 Nov 2005 07:15:04 -0500 Date: Mon, 21 Nov 2005 05:14:54 -0700 From: Matthew Wilcox To: David Howells Cc: Linus Torvalds , Andrew Morton , Ingo Molnar , linux-kernel@vger.kernel.org, Russell King , Ian Molton , Benjamin Herrenschmidt , Paul Mackerras Subject: Re: [PATCH 4/5] Centralise NO_IRQ definition Message-ID: <20051121121454.GA1598@parisc-linux.org> References: <24299.1132571556@warthog.cambridge.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24299.1132571556@warthog.cambridge.redhat.com> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 21, 2005 at 11:12:36AM +0000, David Howells wrote: > Matthew Wilcox wrote: > > > +#define NO_IRQ ((unsigned int)(-1)) > > Should this be wrapped with #ifndef? *sigh*. The one piece of feedback I got on the last series was from Ingo, and he asked that I *not* wrap it with ifndef. So, no.