From: Nick Piggin <nickpiggin@yahoo.com.au>
To: linux-kernel@vger.kernel.org
Cc: Nick Piggin <nickpiggin@yahoo.com.au>, Andrew Morton <akpm@osdl.org>
Subject: [patch 3/12] mm: release opt
Date: Mon, 21 Nov 2005 10:10:43 -0500 [thread overview]
Message-ID: <20051121124025.14370.8515.sendpatchset@didi.local0.net> (raw)
In-Reply-To: <20051121123906.14370.3039.sendpatchset@didi.local0.net>
Optimise some pagevec functions by not reenabling irqs while
switching lru locks.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Index: linux-2.6/mm/swap.c
===================================================================
--- linux-2.6.orig/mm/swap.c
+++ linux-2.6/mm/swap.c
@@ -220,10 +220,13 @@ void release_pages(struct page **pages,
pagezone = page_zone(page);
if (pagezone != zone) {
- if (zone)
- spin_unlock_irq(&zone->lru_lock);
+ spin_lock_prefetch(&pagezone->lru_lock);
+ if (!zone)
+ local_irq_disable();
+ else
+ spin_unlock(&zone->lru_lock);
zone = pagezone;
- spin_lock_irq(&zone->lru_lock);
+ spin_lock(&zone->lru_lock);
}
if (TestClearPageLRU(page))
del_page_from_lru(zone, page);
@@ -297,10 +300,12 @@ void __pagevec_lru_add(struct pagevec *p
struct zone *pagezone = page_zone(page);
if (pagezone != zone) {
+ if (!zone)
+ local_irq_disable();
if (zone)
- spin_unlock_irq(&zone->lru_lock);
+ spin_unlock(&zone->lru_lock);
zone = pagezone;
- spin_lock_irq(&zone->lru_lock);
+ spin_lock(&zone->lru_lock);
}
if (TestSetPageLRU(page))
BUG();
@@ -324,10 +329,12 @@ void __pagevec_lru_add_active(struct pag
struct zone *pagezone = page_zone(page);
if (pagezone != zone) {
+ if (!zone)
+ local_irq_disable();
if (zone)
- spin_unlock_irq(&zone->lru_lock);
+ spin_unlock(&zone->lru_lock);
zone = pagezone;
- spin_lock_irq(&zone->lru_lock);
+ spin_lock(&zone->lru_lock);
}
if (TestSetPageLRU(page))
BUG();
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2005-11-21 15:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-21 11:37 [patch 0/12] mm: optimisations Nick Piggin
2005-11-21 11:41 ` [patch 11/12] mm: page_alloc cleanups Nick Piggin
2005-11-21 12:00 ` [patch 7/12] mm: bad_page opt Nick Piggin
2005-11-21 12:00 ` [patch 8/12] mm: remove pcp low Nick Piggin
2005-11-21 12:07 ` [patch 9/12] mm: page_state opt Nick Piggin
2005-11-22 7:54 ` Andrew Morton
2005-11-22 9:04 ` Nick Piggin
2005-11-22 8:08 ` Andrew Morton
2005-11-21 12:08 ` [patch 12/12] mm: rmap opt Nick Piggin
2005-11-22 19:19 ` Hugh Dickins
2005-11-23 0:07 ` Nick Piggin
2005-11-21 13:07 ` [patch 2/12] mm: pagealloc opt Nick Piggin
2005-11-21 13:08 ` [patch 4/12] mm: set_page_refs opt Nick Piggin
2005-11-21 13:23 ` [patch 1/12] mm: free_pages_and_swap_cache opt Nick Piggin
2005-11-21 13:25 ` [patch 5/12] mm: microopt conditions Nick Piggin
2005-11-21 13:27 ` [patch 10/12] mm: page_state fixes Nick Piggin
2005-11-21 14:29 ` [patch 0/12] mm: optimisations Paul Jackson
2005-11-22 0:26 ` Nick Piggin
2005-11-21 15:10 ` Nick Piggin [this message]
2005-11-21 15:12 ` [patch 6/12] mm: remove bad_range Nick Piggin
2005-11-22 12:32 ` Dave Hansen
2005-11-23 2:09 ` Nick Piggin
2005-11-22 8:06 ` [patch 0/12] mm: optimisations Andrew Morton
2005-11-22 10:51 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051121124025.14370.8515.sendpatchset@didi.local0.net \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox