public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Alexander Clouter <alex-kernel@digriz.org.uk>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
	davej@codemonkey.org.uk, blaisorblade@yahoo.it
Subject: Re: [patch 1/1] cpufreq_conservative/ondemand: invert meaning of 'ignore nice'
Date: Mon, 21 Nov 2005 10:29:20 -0500	[thread overview]
Message-ID: <20051121152920.GA29968@redhat.com> (raw)
In-Reply-To: <20051110151111.GA16994@inskipp.digriz.org.uk>

On Thu, Nov 10, 2005 at 03:11:11PM +0000, Alexander Clouter wrote:
 > The use of the 'ignore_nice' sysfs file is confusing to anyone using it.  
 > This removes the sysfs file 'ignore_nice' and in its place creates a 
 > 'ignore_nice_load' entry which defaults to '1'; meaning nice'd processes are 
 > not counted towards the 'business' caclulation.
 > 
 > WARNING: this obvious breaks any userland tools that expected 'ignore_nice' 
 > to exist, to draw attention to this fact it was concluded on the mailing list 
 > that the entry should be removed altogether so the userland app breaks and so 
 > the author can build simple to detect workaround.  Having said that it seems 
 > currently very few tools even make use of this functionality; all I could 
 > find was a Gentoo Wiki entry.
 > 
 > Signed-off-by: Alexander Clouter <alex-kernel@digriz.org.uk>

 > diff -r -u -d linux-2.6.14-rc2.orig/drivers/cpufreq/cpufreq_conservative.c \
 >                 linux-2.6.14-rc2/drivers/cpufreq/cpufreq_conservative.c
 > --- linux-2.6.14-rc2.orig/drivers/cpufreq/cpufreq_conservative.c	2005-10-03 \
 >                 20:05:30.742334750 +0100
 > +++ linux-2.6.14-rc2/drivers/cpufreq/cpufreq_conservative.c	2005-10-06 \
 > 21:10:47.785133750 +0100 @@ -93,7 +93,7 @@
 >  {

This patch is horribly word-wrapped. Please resend.

		Dave

  parent reply	other threads:[~2005-11-21 15:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-10 15:11 [patch 1/1] cpufreq_conservative/ondemand: invert meaning of 'ignore nice' Alexander Clouter
2005-11-10 15:48 ` Con Kolivas
2005-11-10 15:54   ` Alexander Clouter
2005-11-13 19:59   ` Pavel Machek
2005-11-18 12:07   ` Stefan Seyfried
2005-11-21 15:29 ` Dave Jones [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-11-10 17:00 Alexander Clouter
2005-11-10 23:12 ` Con Kolivas
2005-11-11  9:09   ` Alexander Clouter
2005-11-12  3:30 Pallipadi, Venkatesh
2005-11-21 18:17 Alexander Clouter
2005-11-22  1:21 ` Ken Moffat
2005-11-22  2:22   ` Dave Jones
2005-11-22  2:31     ` Con Kolivas
2005-11-22 11:43       ` Ken Moffat
2005-11-22  8:52   ` Alexander Clouter
2005-11-22 11:38     ` Ken Moffat
2005-11-23  9:46 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051121152920.GA29968@redhat.com \
    --to=davej@redhat.com \
    --cc=akpm@osdl.org \
    --cc=alex-kernel@digriz.org.uk \
    --cc=blaisorblade@yahoo.it \
    --cc=davej@codemonkey.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox