Re: [PATCH 1/3] cciss: bug fix for hpacucli

[Jens Axboe <axboe@suse.de>]

On Mon, Nov 21 2005, mikem wrote:
> On Mon, Nov 21, 2005 at 09:28:10AM +0100, Jens Axboe wrote:
> > On Fri, Nov 18 2005, Jens Axboe wrote:
> > > On Fri, Nov 18 2005, mikem wrote:
> > > > Patch 1 of 3
> > > > 
> > > > This patch fixes a bug that breaks hpacucli, a command line interface
> > > > for the HP Array Config Utility. Without this fix the utility will
> > > > not detect any controllers in the system. I thought I had already fixed
> > > > this, but I guess not.
> > > > 
> > > > Thanks to all who reported the issue. Please consider this this inclusion.
> > > 
> > > Lovely, hope this makes it able to configure my drives on the tiger now
> > > :).
> > 
> > This sort-of makes it work. I get some complaints about unaligned access
> > when setting up a test array:
> > 
> > => controller slot=0 create type=logicaldrive drives=all raid=1 drivetype=sas
> > .hpacucli(12458): unaligned access to 0x60000fffffcb370e, ip=0x40000000003c8550
> > => controller slot=0 create type=logicaldrive drives=all raid=1 drivetype=sata
> > .hpacucli(12458): unaligned access to 0x60000fffffcb4aee, ip=0x40000000003c8550
> > .hpacucli(12458): unaligned access to 0x60000fffffcb370e, ip=0x40000000003c8550
> > .hpacucli(12458): unaligned access to 0x60000fffffcb370e, ip=0x40000000003c8550
> 
> This seems to be coming out of user space. We'll work with the application
> folks to investigate. There is a library called infomanager that's used
> by the app. There may be an issue there. Call you strace the program and
> send me the results? I haven't seen this in my lab with a vendor kernel.

Sure I'll try, I'll boot the box again tomorrow.

> > Invoking hpacucli again later on makes it trigger a kobj warning:
> > 
> > Badness in kref_get at lib/kref.c:32
> 
> Hmmm, is this with my put_disk patch installed?

Yep, it's with current git HEAD (so all 3 patches you sent).

-- 
Jens Axboe