public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Shut up warnings in net/core/flow.c
@ 2005-11-21 17:38 Russell King
  0 siblings, 0 replies; only message in thread
From: Russell King @ 2005-11-21 17:38 UTC (permalink / raw)
  To: Andrew Morton

Not really a network problem, more a !SMP issue.

net/core/flow.c:295: warning: statement with no effect

flow.c:295:        smp_call_function(flow_cache_flush_per_cpu, &info, 1, 0);

Fix this by converting the macro to an inline function, which
also increases the typechecking for !SMP builds.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

diff --git a/include/linux/smp.h b/include/linux/smp.h
--- a/include/linux/smp.h
+++ b/include/linux/smp.h
@@ -94,7 +94,13 @@ void smp_prepare_boot_cpu(void);
  */
 #define raw_smp_processor_id()			0
 #define hard_smp_processor_id()			0
-#define smp_call_function(func,info,retry,wait)	({ 0; })
+
+static inline int smp_call_function(void (*func) (void *info), void *info,
+				    int retry, int wait)
+{
+	return 0;
+}
+
 #define on_each_cpu(func,info,retry,wait)	({ func(info); 0; })
 static inline void smp_send_reschedule(int cpu) { }
 #define num_booting_cpus()			1

-- 
Russell King

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-11-21 18:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-21 17:38 [PATCH] Shut up warnings in net/core/flow.c Russell King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox