public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: David Singleton <dsingleton@mvista.com>
Cc: Dinakar Guniguntala <dino@in.ibm.com>,
	linux-kernel@vger.kernel.org,
	"David F. Carlson" <dave@chronolytics.com>
Subject: Re: PI BUG with -rt13
Date: Mon, 21 Nov 2005 22:26:53 +0100	[thread overview]
Message-ID: <20051121212653.GA6143@elte.hu> (raw)
In-Reply-To: <43822480.6080301@mvista.com>


* David Singleton <dsingleton@mvista.com> wrote:

> Ingo,
>    here is a patch that provides the correct locking for the rt_mutex 
> backing the robust pthread_mutex.   The patch also unifies the locking 
> for all the robust functions and adds support for pthread_mutexes on 
> the heap.

thanks. Could you split up the patch into a fix and a 'heap' patch (at a 
minimum)?

it's this portion of the 'heap' patch that looks problematic:

> --- base/linux-2.6.14/include/linux/mm.h	2005-11-18 20:36:53.000000000 -0800
> +++ wip/linux-2.6.14/include/linux/mm.h	2005-11-21 10:51:19.000000000 -0800
> @@ -109,6 +109,11 @@
>  #ifdef CONFIG_NUMA
>  	struct mempolicy *vm_policy;	/* NUMA policy for the VMA */
>  #endif
> +#ifdef CONFIG_FUTEX
> +	int robust_init;		/* robust initialized? */
> +	struct list_head robust_list;	/* list of robust futexes in this vma */
> +	struct semaphore robust_sem;	/* semaphore to protect the list */
> +#endif
>  };

why is there per-vma info needed?

Also, what testing did this patch have - should it solve Dinakar's 
problem(s)?

	Ingo

  reply	other threads:[~2005-11-21 21:26 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-17 16:18 PI BUG with -rt13 Dinakar Guniguntala
2005-11-17 16:41 ` Dinakar Guniguntala
2005-11-17 23:03 ` David Singleton
2005-11-18  9:29   ` Ingo Molnar
2005-11-18 13:21     ` Dinakar Guniguntala
2005-11-18 13:27       ` Ingo Molnar
2005-11-18 17:05         ` david singleton
2005-11-18 17:44           ` Ingo Molnar
2005-11-21 19:48             ` David Singleton
2005-11-21 21:26               ` Ingo Molnar [this message]
2005-11-22  2:01                 ` david singleton
2005-11-24 14:57                   ` Ingo Molnar
2005-11-24 20:26                     ` Dinakar Guniguntala
2005-11-24 20:32                       ` Dinakar Guniguntala
2005-11-24 22:25                         ` david singleton
2005-11-25  4:56                         ` david singleton
2005-11-25  7:34                           ` Dinakar Guniguntala
2005-11-25  8:04                             ` Dinakar Guniguntala
2005-11-25  5:04                       ` Ingo Molnar
2005-11-25 13:27                         ` Dinakar Guniguntala
2005-11-25  8:03                   ` Ingo Molnar
2005-11-22  2:13                 ` david singleton
     [not found]                 ` <8D664A17-5B07-11DA-A840-000A959BB91E@mvista.com>
2005-11-22  9:37                   ` Dinakar Guniguntala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051121212653.GA6143@elte.hu \
    --to=mingo@elte.hu \
    --cc=dave@chronolytics.com \
    --cc=dino@in.ibm.com \
    --cc=dsingleton@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox