* RE: bug in drivers/pci/hotplug/ibmphp_pci.c
@ 2005-11-21 15:09 Jordan, William P
2005-11-21 21:33 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Jordan, William P @ 2005-11-21 15:09 UTC (permalink / raw)
To: Greg KH; +Cc: gregkh, linux-kernel
> From: Greg KH [mailto:greg@kroah.com]
> Sent: Friday, November 18, 2005 8:14 PM
>
> Yes it does look like that. Does changing this solve a problem that
you
> have been seeing?
Actually, I am not running this code at all. I am just trying to
understand PCI. While investigating how the IO base and IO limit
registers are used, I noticed this instance where it was used
inconsistently. I can resubmit it if you like, but I cannot vouch for
the patch.
Bill Jordan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bug in drivers/pci/hotplug/ibmphp_pci.c
2005-11-21 15:09 bug in drivers/pci/hotplug/ibmphp_pci.c Jordan, William P
@ 2005-11-21 21:33 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2005-11-21 21:33 UTC (permalink / raw)
To: Jordan, William P; +Cc: Greg KH, linux-kernel
On Mon, Nov 21, 2005 at 10:09:36AM -0500, Jordan, William P wrote:
>
>
> > From: Greg KH [mailto:greg@kroah.com]
> > Sent: Friday, November 18, 2005 8:14 PM
> >
> > Yes it does look like that. Does changing this solve a problem that
> you
> > have been seeing?
>
> Actually, I am not running this code at all. I am just trying to
> understand PCI. While investigating how the IO base and IO limit
> registers are used, I noticed this instance where it was used
> inconsistently. I can resubmit it if you like, but I cannot vouch for
> the patch.
Yes, please resubmit it in the proper format as per
Documentation/SubmittingPatches.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug in drivers/pci/hotplug/ibmphp_pci.c
@ 2005-11-18 14:58 Jordan, William P
2005-11-19 1:14 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Jordan, William P @ 2005-11-18 14:58 UTC (permalink / raw)
To: gregkh, linux-kernel
I noticed what appears to be a cut/paste error in
drivers/pci/hotplug/ibmphp_pci.c:
***************
*** 969,975 ****
debug ("io 32\n");
need_io_upper = TRUE;
}
! if ((io_base & PCI_PREF_RANGE_TYPE_MASK) ==
PCI_PREF_RANGE_TYPE_64) {
debug ("pfmem 64\n");
need_pfmem_upper = TRUE;
}
--- 969,975 ----
debug ("io 32\n");
need_io_upper = TRUE;
}
! if ((pfmem_base & PCI_PREF_RANGE_TYPE_MASK) ==
PCI_PREF_RANGE_TYPE_64) {
debug ("pfmem 64\n");
need_pfmem_upper = TRUE;
}
I've verified that the bug still exists in 2.6.15-rc1
Bill Jordan
Unisys Corporation
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: bug in drivers/pci/hotplug/ibmphp_pci.c
2005-11-18 14:58 Jordan, William P
@ 2005-11-19 1:14 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2005-11-19 1:14 UTC (permalink / raw)
To: Jordan, William P; +Cc: gregkh, linux-kernel
On Fri, Nov 18, 2005 at 09:58:50AM -0500, Jordan, William P wrote:
>
> I noticed what appears to be a cut/paste error in
> drivers/pci/hotplug/ibmphp_pci.c:
Yes it does look like that. Does changing this solve a problem that you
have been seeing?
If so, care to resend this, in the format specified in
Documentation/SubmittingPatches so that I can get the change into the
kernel tree?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-11-21 21:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-21 15:09 bug in drivers/pci/hotplug/ibmphp_pci.c Jordan, William P
2005-11-21 21:33 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2005-11-18 14:58 Jordan, William P
2005-11-19 1:14 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox