From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751116AbVKUWCO (ORCPT ); Mon, 21 Nov 2005 17:02:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751094AbVKUWCO (ORCPT ); Mon, 21 Nov 2005 17:02:14 -0500 Received: from holomorphy.com ([66.93.40.71]:50329 "EHLO holomorphy.com") by vger.kernel.org with ESMTP id S1751116AbVKUWCN (ORCPT ); Mon, 21 Nov 2005 17:02:13 -0500 Date: Mon, 21 Nov 2005 13:57:10 -0800 From: William Lee Irwin III To: Hugh Dickins Cc: Andrew Morton , Takashi Iwai , Russell King , "David S. Miller" , Linus Torvalds , Nick Piggin , Dave Airlie , linux-kernel@vger.kernel.org, alsa-devel@lists.sourceforge.net Subject: Re: [PATCH 12/11] unpaged: fix sound Bad page states Message-ID: <20051121215710.GR6916@holomorphy.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: The Domain of Holomorphy User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 21, 2005 at 06:12:38PM +0000, Hugh Dickins wrote: > Earlier I unifdefed PageCompound, so that snd_pcm_mmap_control_nopage > and others can give out a 0-order component of a higher-order page, > which won't be mistakenly freed when zap_pte_range unmaps it. But > many Bad page states reported a PG_reserved was freed after all: I had > missed that we need to say __GFP_COMP to get compound page behaviour. > Some of these higher-order pages are allocated by snd_malloc_pages, some > by snd_malloc_dev_pages; or if SBUS, by sbus_alloc_consistent - but that > has no gfp arg, so add __GFP_COMP into its sparc32/64 implementations. > I'm still rather puzzled that DRM seems not to need a similar change. > Signed-off-by: Hugh Dickins Acked-by: William Irwin -- wli